Re: [RFC PATCH] x86/vlapic: address a violation of MISRA C:2012 Rule 16.2

2023-11-21 Thread Nicola Vetrini
On 2023-11-21 16:36, Jan Beulich wrote: On 25.10.2023 15:22, Nicola Vetrini wrote: --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1034,10 +1034,10 @@ int guest_wrmsr_x2apic(struct vcpu *v, uint32_t msr, uint64_t val) case APIC_EOI: case APIC_ESR: if ( va

Re: [RFC PATCH] x86/vlapic: address a violation of MISRA C:2012 Rule 16.2

2023-11-21 Thread Jan Beulich
On 25.10.2023 15:22, Nicola Vetrini wrote: > --- a/xen/arch/x86/hvm/vlapic.c > +++ b/xen/arch/x86/hvm/vlapic.c > @@ -1034,10 +1034,10 @@ int guest_wrmsr_x2apic(struct vcpu *v, uint32_t msr, > uint64_t val) > case APIC_EOI: > case APIC_ESR: > if ( val ) > -{ > -defaul

Re: [RFC PATCH] x86/vlapic: address a violation of MISRA C:2012 Rule 16.2

2023-11-21 Thread Nicola Vetrini
On 2023-10-25 15:22, Nicola Vetrini wrote: The clauses of a switch should be enclosed directly by a switch statement to make the code more easily understandable and less prone to errors. Signed-off-by: Nicola Vetrini --- This patch is mainly indended to probe how the community, especially the

Re: [RFC PATCH] x86/vlapic: address a violation of MISRA C:2012 Rule 16.2

2023-10-25 Thread Nicola Vetrini
On 25/10/2023 15:44, Jan Beulich wrote: On 25.10.2023 15:22, Nicola Vetrini wrote: The clauses of a switch should be enclosed directly by a switch statement to make the code more easily understandable and less prone to errors. Signed-off-by: Nicola Vetrini --- This patch is mainly indended to

Re: [RFC PATCH] x86/vlapic: address a violation of MISRA C:2012 Rule 16.2

2023-10-25 Thread Jan Beulich
On 25.10.2023 15:22, Nicola Vetrini wrote: > The clauses of a switch should be enclosed directly by a switch > statement to make the code more easily understandable and less > prone to errors. > > Signed-off-by: Nicola Vetrini > --- > This patch is mainly indended to probe how the community, espe

[RFC PATCH] x86/vlapic: address a violation of MISRA C:2012 Rule 16.2

2023-10-25 Thread Nicola Vetrini
The clauses of a switch should be enclosed directly by a switch statement to make the code more easily understandable and less prone to errors. Signed-off-by: Nicola Vetrini --- This patch is mainly indended to probe how the community, especially the maintainers, would receive such modifications