Re: [RFC PATCH 01/18] arm: cppcheck: misra rule 20.7 deviations for alternative.h

2022-12-22 Thread Stefano Stabellini
On Thu, 22 Dec 2022, Jan Beulich wrote: > On 22.12.2022 03:01, Stefano Stabellini wrote: > > What do you guys think? Nice automatic 20.7 scans for all patches and > > for staging, but with the undesirable false-positive comments, or > > no-20.7 scans but no comments in the tree? > > Anything

Re: [RFC PATCH 01/18] arm: cppcheck: misra rule 20.7 deviations for alternative.h

2022-12-22 Thread Jan Beulich
On 22.12.2022 03:01, Stefano Stabellini wrote: > What do you guys think? Nice automatic 20.7 scans for all patches and > for staging, but with the undesirable false-positive comments, or > no-20.7 scans but no comments in the tree? Anything automatic which then also bugs submitters about issues

Re: [RFC PATCH 01/18] arm: cppcheck: misra rule 20.7 deviations for alternative.h

2022-12-21 Thread Stefano Stabellini
On Tue, 20 Dec 2022, Julien Grall wrote: > Hi Luca, > > On 20/12/2022 08:50, Luca Fancellu wrote: > > Cppcheck reports violations of rule 20.7 in two macros of > > alternative.h. > > > > The first one is in the __ALT_PTR macro where cppcheck wants to have > > parentheses on the second operand of

Re: [RFC PATCH 01/18] arm: cppcheck: misra rule 20.7 deviations for alternative.h

2022-12-20 Thread Jan Beulich
On 20.12.2022 10:07, Julien Grall wrote: > On 20/12/2022 08:50, Luca Fancellu wrote: >> --- a/docs/misra/false-positive-cppcheck.json >> +++ b/docs/misra/false-positive-cppcheck.json >> @@ -3,6 +3,20 @@ >> "content": [ >> { >> "id": "SAF-0-false-positive-cppcheck", >>

Re: [RFC PATCH 01/18] arm: cppcheck: misra rule 20.7 deviations for alternative.h

2022-12-20 Thread Julien Grall
Hi Luca, On 20/12/2022 08:50, Luca Fancellu wrote: Cppcheck reports violations of rule 20.7 in two macros of alternative.h. The first one is in the __ALT_PTR macro where cppcheck wants to have parentheses on the second operand of a member access operator, which is not allowed from the c

[RFC PATCH 01/18] arm: cppcheck: misra rule 20.7 deviations for alternative.h

2022-12-20 Thread Luca Fancellu
Cppcheck reports violations of rule 20.7 in two macros of alternative.h. The first one is in the __ALT_PTR macro where cppcheck wants to have parentheses on the second operand of a member access operator, which is not allowed from the c language syntax, furthermore, the macro parameter is never