Re: [RFC PATCH 17/18] public: misra rule 20.7 deviation on errno.h

2022-12-21 Thread Jan Beulich
On 21.12.2022 09:46, Luca Fancellu wrote: >> On 20 Dec 2022, at 09:51, Jan Beulich wrote: >> On 20.12.2022 09:50, Luca Fancellu wrote: >>> Cppcheck has found a violation of rule 20.7 for the macro XEN_ERRNO, >>> while the macro parameter is never used as an expression, it doesn't >>> harm the code

Re: [RFC PATCH 17/18] public: misra rule 20.7 deviation on errno.h

2022-12-21 Thread Luca Fancellu
> On 20 Dec 2022, at 09:51, Jan Beulich wrote: > > On 20.12.2022 09:50, Luca Fancellu wrote: >> Cppcheck has found a violation of rule 20.7 for the macro XEN_ERRNO, >> while the macro parameter is never used as an expression, it doesn't >> harm the code or the readability to add parenthesis, s

Re: [RFC PATCH 17/18] public: misra rule 20.7 deviation on errno.h

2022-12-20 Thread Jan Beulich
On 20.12.2022 09:50, Luca Fancellu wrote: > Cppcheck has found a violation of rule 20.7 for the macro XEN_ERRNO, > while the macro parameter is never used as an expression, it doesn't > harm the code or the readability to add parenthesis, so add them. > > This finding is reported also by eclair an

[RFC PATCH 17/18] public: misra rule 20.7 deviation on errno.h

2022-12-20 Thread Luca Fancellu
Cppcheck has found a violation of rule 20.7 for the macro XEN_ERRNO, while the macro parameter is never used as an expression, it doesn't harm the code or the readability to add parenthesis, so add them. This finding is reported also by eclair and coverity. Signed-off-by: Luca Fancellu --- xen/