Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-03-09 Thread Matias Ezequiel Vara Larsen
On Tue, Mar 07, 2023 at 05:55:26PM +0100, Jan Beulich wrote: > On 07.03.2023 15:44, Matias Ezequiel Vara Larsen wrote: > > On Thu, Feb 23, 2023 at 01:42:08PM +0100, Jan Beulich wrote: > >> On 23.02.2023 13:16, Matias Ezequiel Vara Larsen wrote: > >>> On Fri, Feb 17, 2023 at 03:10:53PM +0100, Jan

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-03-07 Thread Jan Beulich
On 07.03.2023 15:44, Matias Ezequiel Vara Larsen wrote: > On Thu, Feb 23, 2023 at 01:42:08PM +0100, Jan Beulich wrote: >> On 23.02.2023 13:16, Matias Ezequiel Vara Larsen wrote: >>> On Fri, Feb 17, 2023 at 03:10:53PM +0100, Jan Beulich wrote: On 17.02.2023 10:29, Matias Ezequiel Vara Larsen

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-03-07 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 23, 2023 at 01:42:08PM +0100, Jan Beulich wrote: > On 23.02.2023 13:16, Matias Ezequiel Vara Larsen wrote: > > On Fri, Feb 17, 2023 at 03:10:53PM +0100, Jan Beulich wrote: > >> On 17.02.2023 10:29, Matias Ezequiel Vara Larsen wrote: > >>> On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-23 Thread Jan Beulich
On 23.02.2023 13:16, Matias Ezequiel Vara Larsen wrote: > On Fri, Feb 17, 2023 at 03:10:53PM +0100, Jan Beulich wrote: >> On 17.02.2023 10:29, Matias Ezequiel Vara Larsen wrote: >>> On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan Beulich wrote: On 17.02.2023 09:50, Matias Ezequiel Vara Larsen

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-23 Thread Matias Ezequiel Vara Larsen
On Fri, Feb 17, 2023 at 03:10:53PM +0100, Jan Beulich wrote: > On 17.02.2023 10:29, Matias Ezequiel Vara Larsen wrote: > > On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan Beulich wrote: > >> On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: > >>> On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-21 Thread Jan Beulich
On 20.02.2023 17:51, Matias Ezequiel Vara Larsen wrote: > On Thu, Feb 16, 2023 at 04:15:29PM +0100, Jan Beulich wrote: >> On 16.02.2023 16:07, Matias Ezequiel Vara Larsen wrote: >>> On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: On 07.10.2022 14:39, Matias Ezequiel Vara Larsen

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-20 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 16, 2023 at 04:15:29PM +0100, Jan Beulich wrote: > On 16.02.2023 16:07, Matias Ezequiel Vara Larsen wrote: > > On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: > >> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > >>> @@ -287,6 +289,20 @@ static inline void

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-17 Thread Jan Beulich
On 17.02.2023 10:29, Matias Ezequiel Vara Larsen wrote: > On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan Beulich wrote: >> On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: >>> On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: On 14.12.2022 08:29, Jan Beulich wrote: > On

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-17 Thread Matias Ezequiel Vara Larsen
On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan Beulich wrote: > On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: > > On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: > >> On 14.12.2022 08:29, Jan Beulich wrote: > >>> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-17 Thread Jan Beulich
On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: > On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: >> On 14.12.2022 08:29, Jan Beulich wrote: >>> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: +static int stats_vcpu_alloc_mfn(struct domain *d) +{ +

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-17 Thread Matias Ezequiel Vara Larsen
On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: > On 14.12.2022 08:29, Jan Beulich wrote: > > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > >> +static int stats_vcpu_alloc_mfn(struct domain *d) > >> +{ > >> +struct page_info *pg; > >> + > >> +pg =

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-16 Thread Jan Beulich
On 16.02.2023 16:07, Matias Ezequiel Vara Larsen wrote: > On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: >> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>> @@ -287,6 +289,20 @@ static inline void vcpu_runstate_change( >>> } >>> >>> v->runstate.state =

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-16 Thread Jan Beulich
On 16.02.2023 15:48, Matias Ezequiel Vara Larsen wrote: > On Tue, Dec 13, 2022 at 06:02:55PM +0100, Jan Beulich wrote: >> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>> This commit proposes a new mechanism to query the RUNSTATE_running counter >>> for >>> a given vcpu from a dom0

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-16 Thread Matias Ezequiel Vara Larsen
On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > > --- a/xen/common/memory.c > > +++ b/xen/common/memory.c > > @@ -1078,6 +1078,12 @@ unsigned int ioreq_server_max_frames(const struct > > domain *d) > > return nr; > >

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-16 Thread Matias Ezequiel Vara Larsen
Hello Jan and thanks for your comments. I addressed most of the them but I've still some questions. Please find my questions below: On Tue, Dec 13, 2022 at 06:02:55PM +0100, Jan Beulich wrote: > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > > This commit proposes a new mechanism to

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2022-12-13 Thread Jan Beulich
On 14.12.2022 08:29, Jan Beulich wrote: > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >> +static int stats_vcpu_alloc_mfn(struct domain *d) >> +{ >> +struct page_info *pg; >> + >> +pg = alloc_domheap_page(d, MEMF_no_refcount); > > The ioreq and vmtrace resources are also

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2022-12-13 Thread Jan Beulich
On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -1078,6 +1078,12 @@ unsigned int ioreq_server_max_frames(const struct > domain *d) > return nr; > } > > +unsigned int stats_table_max_frames(const struct domain *d) > +{ >

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2022-12-13 Thread Jan Beulich
On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > This commit proposes a new mechanism to query the RUNSTATE_running counter for > a given vcpu from a dom0 userspace application. This commit proposes to expose > that counter by using the acquire_resource interface. The current mechanism >

[RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2022-10-07 Thread Matias Ezequiel Vara Larsen
This commit proposes a new mechanism to query the RUNSTATE_running counter for a given vcpu from a dom0 userspace application. This commit proposes to expose that counter by using the acquire_resource interface. The current mechanism relies on the XEN_DOMCTL_getvcpuinfo and holds a single global