Re: [RFC PATCH v2 2/2] tools/misc: Add xen-vcpus-stats tool

2023-03-29 Thread Julien Grall
Hi, Sorry for the late reply. On 17/03/2023 11:01, Matias Ezequiel Vara Larsen wrote: On Thu, Feb 23, 2023 at 08:31:29PM +, Julien Grall wrote: +#define rmb()   asm volatile("lfence":::"memory") This is rmb(), but rmb() isn't what you want. You want smp_rmb(), which is #define

Re: [RFC PATCH v2 2/2] tools/misc: Add xen-vcpus-stats tool

2023-03-17 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 23, 2023 at 08:31:29PM +, Julien Grall wrote: > Hi, > > On 23/02/2023 16:01, Andrew Cooper wrote: > > On 07/10/2022 1:39 pm, Matias Ezequiel Vara Larsen wrote: > > > > A couple of observations, all unrelated to the stats themselves. > > > > Although overall, I'm not entirely

Re: [RFC PATCH v2 2/2] tools/misc: Add xen-vcpus-stats tool

2023-02-24 Thread Matias Ezequiel Vara Larsen
Hello Andrew and thanks for the comments, On Thu, Feb 23, 2023 at 04:01:09PM +, Andrew Cooper wrote: > On 07/10/2022 1:39 pm, Matias Ezequiel Vara Larsen wrote: > > A couple of observations, all unrelated to the stats themselves. > > Although overall, I'm not entirely certain that a tool

Re: [RFC PATCH v2 2/2] tools/misc: Add xen-vcpus-stats tool

2023-02-23 Thread Julien Grall
Hi, On 23/02/2023 16:01, Andrew Cooper wrote: On 07/10/2022 1:39 pm, Matias Ezequiel Vara Larsen wrote: A couple of observations, all unrelated to the stats themselves. Although overall, I'm not entirely certain that a tool like this is going to be very helpful after initial development. 

Re: [RFC PATCH v2 2/2] tools/misc: Add xen-vcpus-stats tool

2023-02-23 Thread Andrew Cooper
On 07/10/2022 1:39 pm, Matias Ezequiel Vara Larsen wrote: A couple of observations, all unrelated to the stats themselves. Although overall, I'm not entirely certain that a tool like this is going to be very helpful after initial development.  Something to consider would be to alter libxenstat

[RFC PATCH v2 2/2] tools/misc: Add xen-vcpus-stats tool

2022-10-07 Thread Matias Ezequiel Vara Larsen
Add a demonstration tool that uses the stats_table resource to query vcpus' RUNSTATE_running counter for a DomU. Signed-off-by: Matias Ezequiel Vara Larsen --- Changes in v2: - use period instead of frec - rely on version to ensure reading is coherent Changes in v1: - change the name of the