Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-08 Thread Chen, Jiqian
On 2024/1/8 17:25, Jan Beulich wrote: > On 08.01.2024 10:15, Chen, Jiqian wrote: >> On 2024/1/8 16:47, Jan Beulich wrote: >>> On 06.01.2024 01:46, Stefano Stabellini wrote: On Fri, 5 Jan 2024, Jiqian Chen wrote: > @@ -72,8 +73,30 @@ long hvm_physdev_op(int cmd, > XEN_GUEST_HANDLE_PARA

Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-08 Thread Jan Beulich
On 08.01.2024 10:15, Chen, Jiqian wrote: > On 2024/1/8 16:47, Jan Beulich wrote: >> On 06.01.2024 01:46, Stefano Stabellini wrote: >>> On Fri, 5 Jan 2024, Jiqian Chen wrote: @@ -72,8 +73,30 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) switch ( cmd )

Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-08 Thread Chen, Jiqian
On 2024/1/8 16:47, Jan Beulich wrote: > On 06.01.2024 01:46, Stefano Stabellini wrote: >> On Fri, 5 Jan 2024, Jiqian Chen wrote: >>> @@ -72,8 +73,30 @@ long hvm_physdev_op(int cmd, >>> XEN_GUEST_HANDLE_PARAM(void) arg) >>> >>> switch ( cmd ) >>> { >>> -case PHYSDEVOP_map_pirq: >>>

Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-08 Thread Jan Beulich
On 06.01.2024 01:46, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: >> @@ -72,8 +73,30 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) >> arg) >> >> switch ( cmd ) >> { >> -case PHYSDEVOP_map_pirq: >> -case PHYSDEVOP_unmap_pirq: >> +case PHY

Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Jiqian Chen wrote: > If run Xen with PVH dom0 and hvm domU, hvm will map a pirq for > a passthrough device by using gsi, see > xen_pt_realize->xc_physdev_map_pirq and > pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq > will call into Xen, but in hvm_physdev_op, PH

[RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-04 Thread Jiqian Chen
If run Xen with PVH dom0 and hvm domU, hvm will map a pirq for a passthrough device by using gsi, see xen_pt_realize->xc_physdev_map_pirq and pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq will call into Xen, but in hvm_physdev_op, PHYSDEVOP_map_pirq is not allowed because currd is