Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-21 Thread Julien Grall
Hi Andrew, On 16/03/2022 18:58, Andrew Cooper wrote: diff --git a/xen/common/event_fifo.c b/xen/common/event_fifo.c index ed4d3beb10f3..6c74ccebebb7 100644 --- a/xen/common/event_fifo.c +++ b/xen/common/event_fifo.c @@ -165,7 +165,7 @@ static void cf_check evtchn_fifo_set_pending(

Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-21 Thread David Vrabel
On 16/03/2022 18:38, Raphael Ning wrote: Currently, evtchn_fifo_set_pending() will mark the event as PENDING even if it fails to lock the FIFO event queue(s), or if the guest has not initialized the FIFO control block for the target vCPU. A well-behaved guest should never trigger either of these

Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-17 Thread Raphael Ning
On 17/03/2022 14:26, Luca Fancellu wrote: > I’ve tested on the ARM side, I’ve started/destroyed few guests from Dom0, > connect to the console, run > some network communications between guest and Dom0, everything works: > > Tested-by: Luca Fancellu Thanks!  I tested on x86 (in a QEMU VM) by

Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-17 Thread Luca Fancellu
> On 16 Mar 2022, at 18:58, Andrew Cooper wrote: > > On 16/03/2022 18:38, Raphael Ning wrote: >> From: Raphael Ning >> >> Currently, evtchn_fifo_set_pending() will mark the event as PENDING even >> if it fails to lock the FIFO event queue(s), or if the guest has not >> initialized the FIFO

Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-17 Thread Raphael Ning
On 16/03/2022 18:58, Andrew Cooper wrote: > On 16/03/2022 18:38, Raphael Ning wrote: >> From: Raphael Ning >> >> Currently, evtchn_fifo_set_pending() will mark the event as PENDING even >> if it fails to lock the FIFO event queue(s), or if the guest has not >> initialized the FIFO control block

Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-17 Thread David Vrabel
On 17/03/2022 06:28, Juergen Gross wrote: On 16.03.22 19:38, Raphael Ning wrote: From: Raphael Ning Currently, evtchn_fifo_set_pending() will mark the event as PENDING even if it fails to lock the FIFO event queue(s), or if the guest has not initialized the FIFO control block for the

Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-17 Thread Juergen Gross
On 16.03.22 19:38, Raphael Ning wrote: From: Raphael Ning Currently, evtchn_fifo_set_pending() will mark the event as PENDING even if it fails to lock the FIFO event queue(s), or if the guest has not initialized the FIFO control block for the target vCPU. A well-behaved guest should never

Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-16 Thread Andrew Cooper
On 16/03/2022 18:38, Raphael Ning wrote: > From: Raphael Ning > > Currently, evtchn_fifo_set_pending() will mark the event as PENDING even > if it fails to lock the FIFO event queue(s), or if the guest has not > initialized the FIFO control block for the target vCPU. A well-behaved > guest should

[XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

2022-03-16 Thread Raphael Ning
From: Raphael Ning Currently, evtchn_fifo_set_pending() will mark the event as PENDING even if it fails to lock the FIFO event queue(s), or if the guest has not initialized the FIFO control block for the target vCPU. A well-behaved guest should never trigger either of these cases. There is no