Re: [XEN PATCH] ioreq: include arch-specific ioreq header in

2023-09-01 Thread Nicola Vetrini
On 01/09/2023 11:44, Jan Beulich wrote: On 01.09.2023 11:13, Nicola Vetrini wrote: On 01/09/2023 09:36, Jan Beulich wrote: On 01.09.2023 09:13, Nicola Vetrini wrote: On 28/08/2023 09:59, Jan Beulich wrote: On 25.08.2023 17:02, Nicola Vetrini wrote: The common header file for ioreq should inc

Re: [XEN PATCH] ioreq: include arch-specific ioreq header in

2023-09-01 Thread Jan Beulich
On 01.09.2023 11:13, Nicola Vetrini wrote: > On 01/09/2023 09:36, Jan Beulich wrote: >> On 01.09.2023 09:13, Nicola Vetrini wrote: >>> On 28/08/2023 09:59, Jan Beulich wrote: On 25.08.2023 17:02, Nicola Vetrini wrote: > The common header file for ioreq should include the arch-specific >>>

Re: [XEN PATCH] ioreq: include arch-specific ioreq header in

2023-09-01 Thread Nicola Vetrini
On 01/09/2023 09:36, Jan Beulich wrote: On 01.09.2023 09:13, Nicola Vetrini wrote: On 28/08/2023 09:59, Jan Beulich wrote: On 25.08.2023 17:02, Nicola Vetrini wrote: The common header file for ioreq should include the arch-specific one. To be honest I'm not convinced of "should" here. There

Re: [XEN PATCH] ioreq: include arch-specific ioreq header in

2023-09-01 Thread Jan Beulich
On 01.09.2023 09:13, Nicola Vetrini wrote: > On 28/08/2023 09:59, Jan Beulich wrote: >> On 25.08.2023 17:02, Nicola Vetrini wrote: >>> The common header file for ioreq should include the arch-specific one. >> >> To be honest I'm not convinced of "should" here. There are two aspects >> to consider:

Re: [XEN PATCH] ioreq: include arch-specific ioreq header in

2023-09-01 Thread Nicola Vetrini
On 28/08/2023 09:59, Jan Beulich wrote: On 25.08.2023 17:02, Nicola Vetrini wrote: The common header file for ioreq should include the arch-specific one. To be honest I'm not convinced of "should" here. There are two aspects to consider: On one hand it is good practice to do what you say. Otoh

Re: [XEN PATCH] ioreq: include arch-specific ioreq header in

2023-08-28 Thread Jan Beulich
On 25.08.2023 17:02, Nicola Vetrini wrote: > The common header file for ioreq should include the arch-specific one. To be honest I'm not convinced of "should" here. There are two aspects to consider: On one hand it is good practice to do what you say. Otoh it introduces a needless dependency, and

Re: [XEN PATCH] ioreq: include arch-specific ioreq header in

2023-08-25 Thread Stefano Stabellini
On Fri, 25 Aug 2023, Nicola Vetrini wrote: > The common header file for ioreq should include the arch-specific one. > This also addresses violations of MISRA C:2012 Rule 8.4 caused by the missing > inclusion of in the arm implementation file. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefa

[XEN PATCH] ioreq: include arch-specific ioreq header in

2023-08-25 Thread Nicola Vetrini
The common header file for ioreq should include the arch-specific one. This also addresses violations of MISRA C:2012 Rule 8.4 caused by the missing inclusion of in the arm implementation file. Signed-off-by: Nicola Vetrini --- - The deleted includes are therefore no longer necessary, since is