Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

2023-08-30 Thread Simone Ballarin
On 30/08/23 15:01, Jan Beulich wrote: On 30.08.2023 14:53, Simone Ballarin wrote: On 29/08/23 00:10, Julien Grall wrote: On Mon, 28 Aug 2023 at 09:20, Simone Ballarin wrote: --- a/xen/arch/arm/include/asm/hypercall.h +++ b/xen/arch/arm/include/asm/hypercall.h @@ -1,10 +1,10 @@ +#ifndef __ASM_

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

2023-08-30 Thread Jan Beulich
On 30.08.2023 14:53, Simone Ballarin wrote: > On 29/08/23 00:10, Julien Grall wrote: >> On Mon, 28 Aug 2023 at 09:20, Simone Ballarin >> wrote: >>> --- a/xen/arch/arm/include/asm/hypercall.h >>> +++ b/xen/arch/arm/include/asm/hypercall.h >>> @@ -1,10 +1,10 @@ >>> +#ifndef __ASM_ARM_HYPERCALL_H__ >

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

2023-08-30 Thread Simone Ballarin
On 29/08/23 00:10, Julien Grall wrote: Hi, On Mon, 28 Aug 2023 at 09:20, Simone Ballarin wrote: Add or move inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). In

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

2023-08-28 Thread Julien Grall
Hi, On Mon, 28 Aug 2023 at 09:20, Simone Ballarin wrote: > Add or move inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Inclusion guards must appear at t

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

2023-08-28 Thread Stefano Stabellini
On Mon, 28 Aug 2023, Simone Ballarin wrote: > Add or move inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Inclusion guards must appear at the beginning of

[XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

2023-08-28 Thread Simone Ballarin
Add or move inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards must appear at the beginning of the headers (comments are permitted anywhere). Mechani