Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-23 Thread Simone Ballarin
On 20/10/23 10:28, Julien Grall wrote: Hi Stefano, On 19/10/2023 19:30, Stefano Stabellini wrote: We usually use this trick when 'current' is used multiple time to save process (using 'current' is not cost free). But in this case, this is renaming without any apparent benefits. If we wanted to

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-20 Thread Julien Grall
Hi Stefano, On 19/10/2023 19:30, Stefano Stabellini wrote: We usually use this trick when 'current' is used multiple time to save process (using 'current' is not cost free). But in this case, this is renaming without any apparent benefits. If we wanted to go down this route, then this would lik

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-19 Thread Stefano Stabellini
On Thu, 19 Oct 2023, Simone Ballarin wrote: > On 19/10/23 14:30, Julien Grall wrote: > > Hi, > > > > On 19/10/2023 12:10, Simone Ballarin wrote: > > > On 19/10/23 12:11, Julien Grall wrote: > > > > Hi, > > > > > > > > On 19/10/2023 09:43, Simone Ballarin wrote: > > > > > On 19/10/23 10:19, Julien

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-19 Thread Simone Ballarin
On 19/10/23 14:30, Julien Grall wrote: Hi, On 19/10/2023 12:10, Simone Ballarin wrote: On 19/10/23 12:11, Julien Grall wrote: Hi, On 19/10/2023 09:43, Simone Ballarin wrote: On 19/10/23 10:19, Julien Grall wrote: Hi Simone, On 19/10/2023 08:34, Simone Ballarin wrote: On 18/10/23 17:03, Ju

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-19 Thread Julien Grall
Hi, On 19/10/2023 12:10, Simone Ballarin wrote: On 19/10/23 12:11, Julien Grall wrote: Hi, On 19/10/2023 09:43, Simone Ballarin wrote: On 19/10/23 10:19, Julien Grall wrote: Hi Simone, On 19/10/2023 08:34, Simone Ballarin wrote: On 18/10/23 17:03, Julien Grall wrote: Hi, On 18/10/2023 15

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-19 Thread Simone Ballarin
On 19/10/23 12:11, Julien Grall wrote: Hi, On 19/10/2023 09:43, Simone Ballarin wrote: On 19/10/23 10:19, Julien Grall wrote: Hi Simone, On 19/10/2023 08:34, Simone Ballarin wrote: On 18/10/23 17:03, Julien Grall wrote: Hi, On 18/10/2023 15:18, Simone Ballarin wrote: Rule 13.1: Initializer

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-19 Thread Julien Grall
Hi, On 19/10/2023 09:43, Simone Ballarin wrote: On 19/10/23 10:19, Julien Grall wrote: Hi Simone, On 19/10/2023 08:34, Simone Ballarin wrote: On 18/10/23 17:03, Julien Grall wrote: Hi, On 18/10/2023 15:18, Simone Ballarin wrote: Rule 13.1: Initializer lists shall not contain persistent sid

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-19 Thread Simone Ballarin
On 19/10/23 10:19, Julien Grall wrote: Hi Simone, On 19/10/2023 08:34, Simone Ballarin wrote: On 18/10/23 17:03, Julien Grall wrote: Hi, On 18/10/2023 15:18, Simone Ballarin wrote: Rule 13.1: Initializer lists shall not contain persistent side effects This patch moves expressions with side-

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-19 Thread Julien Grall
Hi Simone, On 19/10/2023 08:34, Simone Ballarin wrote: On 18/10/23 17:03, Julien Grall wrote: Hi, On 18/10/2023 15:18, Simone Ballarin wrote: Rule 13.1: Initializer lists shall not contain persistent side effects This patch moves expressions with side-effects into new variables before the in

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-19 Thread Simone Ballarin
On 18/10/23 17:03, Julien Grall wrote: Hi, On 18/10/2023 15:18, Simone Ballarin wrote: Rule 13.1: Initializer lists shall not contain persistent side effects This patch moves expressions with side-effects into new variables before the initializer lists. Looking at the code, I feel the commit

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-18 Thread Stefano Stabellini
On Wed, 18 Oct 2023, Julien Grall wrote: > Hi, > > On 18/10/2023 15:18, Simone Ballarin wrote: > > Rule 13.1: Initializer lists shall not contain persistent side effects > > > > This patch moves expressions with side-effects into new variables before > > the initializer lists. > > Looking at the

Re: [XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-18 Thread Julien Grall
Hi, On 18/10/2023 15:18, Simone Ballarin wrote: Rule 13.1: Initializer lists shall not contain persistent side effects This patch moves expressions with side-effects into new variables before the initializer lists. Looking at the code, I feel the commit message should be a bit more verbose b

[XEN PATCH 1/4] xen/arm: address violations of MISRA C:2012 Rule 13.1

2023-10-18 Thread Simone Ballarin
Rule 13.1: Initializer lists shall not contain persistent side effects This patch moves expressions with side-effects into new variables before the initializer lists. Function calls do not necessarily have side-effects, in these cases the GCC pure or const attributes are added when possible. No