Re: [XEN PATCH 1/9] x86/boot: choose AP stack based on APIC ID

2024-03-12 Thread Jan Beulich
On 12.03.2024 16:11, Krystian Hebel wrote: > On 7.02.2024 17:11, Jan Beulich wrote: >> On 14.11.2023 18:49, Krystian Hebel wrote: >>> --- a/xen/arch/x86/boot/trampoline.S >>> +++ b/xen/arch/x86/boot/trampoline.S >>> +/* Not x2APIC, read from MMIO */ >>> +mov 0xfee00020, %esp >>

Re: [XEN PATCH 1/9] x86/boot: choose AP stack based on APIC ID

2024-03-12 Thread Krystian Hebel
On 7.02.2024 17:11, Jan Beulich wrote: On 14.11.2023 18:49, Krystian Hebel wrote: --- a/xen/arch/x86/boot/trampoline.S +++ b/xen/arch/x86/boot/trampoline.S @@ -72,6 +72,26 @@ trampoline_protmode_entry: mov $X86_CR4_PAE,%ecx mov %ecx,%cr4 +/* + *

Re: [XEN PATCH 1/9] x86/boot: choose AP stack based on APIC ID

2024-03-12 Thread Krystian Hebel
Hi, On 26.01.2024 19:30, Julien Grall wrote: Hi, I am not too familiary with the x86 boot code. But I will give a try to review :). On 14/11/2023 17:49, Krystian Hebel wrote: This is made as first step of making parallel AP bring-up possible. It should be enough for pre-C code.

Re: [XEN PATCH 1/9] x86/boot: choose AP stack based on APIC ID

2024-02-07 Thread Jan Beulich
On 14.11.2023 18:49, Krystian Hebel wrote: > --- a/xen/arch/x86/boot/trampoline.S > +++ b/xen/arch/x86/boot/trampoline.S > @@ -72,6 +72,26 @@ trampoline_protmode_entry: > mov $X86_CR4_PAE,%ecx > mov %ecx,%cr4 > > +/* > + * Get APIC ID while we're in

Re: [XEN PATCH 1/9] x86/boot: choose AP stack based on APIC ID

2024-01-26 Thread Julien Grall
Hi, I am not too familiary with the x86 boot code. But I will give a try to review :). On 14/11/2023 17:49, Krystian Hebel wrote: This is made as first step of making parallel AP bring-up possible. It should be enough for pre-C code. Signed-off-by: Krystian Hebel ---

[XEN PATCH 1/9] x86/boot: choose AP stack based on APIC ID

2023-11-14 Thread Krystian Hebel
This is made as first step of making parallel AP bring-up possible. It should be enough for pre-C code. Signed-off-by: Krystian Hebel --- xen/arch/x86/boot/trampoline.S | 20 xen/arch/x86/boot/x86_64.S | 28 +++- xen/arch/x86/setup.c |