Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-10 Thread Federico Serafini
On 08/01/24 15:44, Jan Beulich wrote: On 08.01.2024 15:01, Federico Serafini wrote: Additionally, looking at violations of 16.3 on X86 [1], I think we should also consider generate_exception(), ASSERT_UNREACHABLE() and PARSE_ERR_RET() as allowed terminals for a switch-clause, do you agree?

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Jan Beulich
On 08.01.2024 15:01, Federico Serafini wrote: > Additionally, looking at violations of 16.3 on X86 [1], > I think we should also consider generate_exception(), > ASSERT_UNREACHABLE() and PARSE_ERR_RET() as allowed terminals > for a switch-clause, do you agree? No, and iirc this was discussed

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Federico Serafini
On 08/01/24 12:36, Jan Beulich wrote: On 08.01.2024 12:16, Federico Serafini wrote: On 08/01/24 09:02, Jan Beulich wrote: On 05.01.2024 17:19, Federico Serafini wrote: Hello everyone, On 21/12/23 13:41, Jan Beulich wrote: On 21.12.2023 13:01, Nicola Vetrini wrote: Hi Andrew, On 2023-12-21

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Jan Beulich
On 08.01.2024 12:16, Federico Serafini wrote: > On 08/01/24 09:02, Jan Beulich wrote: >> On 05.01.2024 17:19, Federico Serafini wrote: >>> Hello everyone, >>> >>> On 21/12/23 13:41, Jan Beulich wrote: On 21.12.2023 13:01, Nicola Vetrini wrote: > Hi Andrew, > > On 2023-12-21 12:03,

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Federico Serafini
On 08/01/24 09:02, Jan Beulich wrote: On 05.01.2024 17:19, Federico Serafini wrote: Hello everyone, On 21/12/23 13:41, Jan Beulich wrote: On 21.12.2023 13:01, Nicola Vetrini wrote: Hi Andrew, On 2023-12-21 12:03, Andrew Cooper wrote: On 21/12/2023 10:58 am, Jan Beulich wrote: On

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Jan Beulich
On 05.01.2024 23:48, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Federico Serafini wrote: >> Hello everyone, >> >> On 21/12/23 13:41, Jan Beulich wrote: >>> On 21.12.2023 13:01, Nicola Vetrini wrote: Hi Andrew, On 2023-12-21 12:03, Andrew Cooper wrote: > On 21/12/2023 10:58

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Jan Beulich
On 05.01.2024 17:19, Federico Serafini wrote: > Hello everyone, > > On 21/12/23 13:41, Jan Beulich wrote: >> On 21.12.2023 13:01, Nicola Vetrini wrote: >>> Hi Andrew, >>> >>> On 2023-12-21 12:03, Andrew Cooper wrote: On 21/12/2023 10:58 am, Jan Beulich wrote: > On 21.12.2023 11:53,

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Federico Serafini wrote: > Hello everyone, > > On 21/12/23 13:41, Jan Beulich wrote: > > On 21.12.2023 13:01, Nicola Vetrini wrote: > > > Hi Andrew, > > > > > > On 2023-12-21 12:03, Andrew Cooper wrote: > > > > On 21/12/2023 10:58 am, Jan Beulich wrote: > > > > > On

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-05 Thread Federico Serafini
Hello everyone, On 21/12/23 13:41, Jan Beulich wrote: On 21.12.2023 13:01, Nicola Vetrini wrote: Hi Andrew, On 2023-12-21 12:03, Andrew Cooper wrote: On 21/12/2023 10:58 am, Jan Beulich wrote: On 21.12.2023 11:53, Federico Serafini wrote: Remove declarations of __put_user_bad() and

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2023-12-21 Thread Jan Beulich
On 21.12.2023 13:01, Nicola Vetrini wrote: > Hi Andrew, > > On 2023-12-21 12:03, Andrew Cooper wrote: >> On 21/12/2023 10:58 am, Jan Beulich wrote: >>> On 21.12.2023 11:53, Federico Serafini wrote: Remove declarations of __put_user_bad() and __get_user_bad() since they have no

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2023-12-21 Thread Nicola Vetrini
Hi Andrew, On 2023-12-21 12:03, Andrew Cooper wrote: On 21/12/2023 10:58 am, Jan Beulich wrote: On 21.12.2023 11:53, Federico Serafini wrote: Remove declarations of __put_user_bad() and __get_user_bad() since they have no definition. Replace their uses with a break statement to address

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2023-12-21 Thread Andrew Cooper
On 21/12/2023 10:58 am, Jan Beulich wrote: > On 21.12.2023 11:53, Federico Serafini wrote: >> Remove declarations of __put_user_bad() and __get_user_bad() >> since they have no definition. >> Replace their uses with a break statement to address violations of >> MISRA C:2012 Rule 16.3 ("An

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2023-12-21 Thread Jan Beulich
On 21.12.2023 11:53, Federico Serafini wrote: > Remove declarations of __put_user_bad() and __get_user_bad() > since they have no definition. > Replace their uses with a break statement to address violations of > MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall > terminate every

[XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2023-12-21 Thread Federico Serafini
Remove declarations of __put_user_bad() and __get_user_bad() since they have no definition. Replace their uses with a break statement to address violations of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No functional change. Signed-off-by: