Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2022-01-20 Thread Ayan Kumar Halder
Hi Andre/All, Many thanks for your feedback. On 11/01/2022 12:52, Andre Przywara wrote: On Mon, 10 Jan 2022 14:33:11 + Ayan Kumar Halder wrote: Hi Ayan, Many thanks for your inputs. It is making better sense now. Much appreciated. A few questions/clarifications :- On 06/01/2022

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2022-01-11 Thread Andre Przywara
On Mon, 10 Jan 2022 14:33:11 + Ayan Kumar Halder wrote: Hi Ayan, > Many thanks for your inputs. It is making better sense now. Much > appreciated. > > A few questions/clarifications :- > > On 06/01/2022 15:33, Andre Przywara wrote: > > On Wed, 5 Jan 2022 16:55:11 + > > Ayan Kumar

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2022-01-10 Thread Ayan Kumar Halder
Hi Andre, Many thanks for your inputs. It is making better sense now. Much appreciated. A few questions/clarifications :- On 06/01/2022 15:33, Andre Przywara wrote: On Wed, 5 Jan 2022 16:55:11 + Ayan Kumar Halder wrote: Hi, Thank you so much for your feedback. I need a couple of

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2022-01-06 Thread Andre Przywara
On Wed, 5 Jan 2022 16:55:11 + Ayan Kumar Halder wrote: Hi, > Thank you so much for your feedback. > > I need a couple of clarifications before I can start with the v3 patch. > > On 08/12/2021 12:00, Andre Przywara wrote: > > On Mon, 6 Dec 2021 19:31:06 + > > Julien Grall wrote: > > >

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2022-01-05 Thread Ayan Kumar Halder
Hi, Thank you so much for your feedback. I need a couple of clarifications before I can start with the v3 patch. On 08/12/2021 12:00, Andre Przywara wrote: On Mon, 6 Dec 2021 19:31:06 + Julien Grall wrote: Hi, On 01/12/2021 08:41, Bertrand Marquis wrote: Hi Ayan, On 30 Nov 2021,

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-12-08 Thread Andre Przywara
On Mon, 6 Dec 2021 19:31:06 + Julien Grall wrote: Hi, > On 01/12/2021 08:41, Bertrand Marquis wrote: > > Hi Ayan, > > > >> On 30 Nov 2021, at 19:13, Ayan Kumar Halder > >> wrote: > >> > >> Hi Andre, > >> > >> Thanks for your comments. They are useful. > >> > >> On 30/11/2021 09:49,

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-12-06 Thread Stefano Stabellini
On Mon, 6 Dec 2021, Julien Grall wrote: > On 01/12/2021 08:41, Bertrand Marquis wrote: > > Hi Ayan, > > > > > On 30 Nov 2021, at 19:13, Ayan Kumar Halder > > > wrote: > > > > > > Hi Andre, > > > > > > Thanks for your comments. They are useful. > > > > > > On 30/11/2021 09:49, Andre Przywara

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-12-06 Thread Julien Grall
Hi all, On 01/12/2021 08:41, Bertrand Marquis wrote: Hi Ayan, On 30 Nov 2021, at 19:13, Ayan Kumar Halder wrote: Hi Andre, Thanks for your comments. They are useful. On 30/11/2021 09:49, Andre Przywara wrote: On Mon, 29 Nov 2021 19:16:38 + Ayan Kumar Halder wrote: Hi, At the

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-12-01 Thread Jan Beulich
On 01.12.2021 12:58, Andre Przywara wrote: > On Tue, 30 Nov 2021 19:13:41 + > Ayan Kumar Halder wrote: >> On 30/11/2021 09:49, Andre Przywara wrote: >>> On Mon, 29 Nov 2021 19:16:38 + >>> Ayan Kumar Halder wrote: At the moment, Xen is only handling data abort with valid syndrome

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-12-01 Thread Andre Przywara
On Tue, 30 Nov 2021 19:13:41 + Ayan Kumar Halder wrote: Hi Ayan, > Thanks for your comments. They are useful. > > On 30/11/2021 09:49, Andre Przywara wrote: > > On Mon, 29 Nov 2021 19:16:38 + > > Ayan Kumar Halder wrote: > > > > Hi, > > > >> At the moment, Xen is only handling

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-12-01 Thread Andre Przywara
On Wed, 1 Dec 2021 08:41:13 + Bertrand Marquis wrote: Hi, > > On 30 Nov 2021, at 19:13, Ayan Kumar Halder > > wrote: > > > > Hi Andre, > > > > Thanks for your comments. They are useful. > > > > On 30/11/2021 09:49, Andre Przywara wrote: > >> On Mon, 29 Nov 2021 19:16:38 + > >> Ayan

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-12-01 Thread Bertrand Marquis
Hi Ayan, > On 30 Nov 2021, at 19:13, Ayan Kumar Halder > wrote: > > Hi Andre, > > Thanks for your comments. They are useful. > > On 30/11/2021 09:49, Andre Przywara wrote: >> On Mon, 29 Nov 2021 19:16:38 + >> Ayan Kumar Halder wrote: >> Hi, >>> At the moment, Xen is only handling data

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-11-30 Thread Jan Beulich
On 30.11.2021 19:35, Ayan Kumar Halder wrote: > On 30/11/2021 07:57, Jan Beulich wrote: >> On 29.11.2021 20:16, Ayan Kumar Halder wrote: >>> +{ >>> +struct cpu_user_regs *regs = guest_cpu_user_regs(); >>> +unsigned int val; >>> + >>> +val = get_user_reg(regs, instr->code.rn); >>> +

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-11-30 Thread Ayan Kumar Halder
Hi Andre, Thanks for your comments. They are useful. On 30/11/2021 09:49, Andre Przywara wrote: On Mon, 29 Nov 2021 19:16:38 + Ayan Kumar Halder wrote: Hi, At the moment, Xen is only handling data abort with valid syndrome (i.e. ISV=0). Unfortunately, this doesn't cover all the

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-11-30 Thread Ayan Kumar Halder
Hi Jan, Thanks a lot for the feedback. I need a clarification. On 30/11/2021 07:57, Jan Beulich wrote: On 29.11.2021 20:16, Ayan Kumar Halder wrote: At the moment, Xen is only handling data abort with valid syndrome (i.e. ISV=0). Unfortunately, this doesn't cover all the instructions a domain

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-11-30 Thread Andre Przywara
On Mon, 29 Nov 2021 19:16:38 + Ayan Kumar Halder wrote: Hi, > At the moment, Xen is only handling data abort with valid syndrome (i.e. > ISV=0). Unfortunately, this doesn't cover all the instructions a domain > could use to access MMIO regions. > > For instance, Xilinx baremetal OS will

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-11-29 Thread Jan Beulich
On 29.11.2021 20:16, Ayan Kumar Halder wrote: > At the moment, Xen is only handling data abort with valid syndrome (i.e. > ISV=0). Unfortunately, this doesn't cover all the instructions a domain > could use to access MMIO regions. > > For instance, Xilinx baremetal OS will use: > >

[XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

2021-11-29 Thread Ayan Kumar Halder
At the moment, Xen is only handling data abort with valid syndrome (i.e. ISV=0). Unfortunately, this doesn't cover all the instructions a domain could use to access MMIO regions. For instance, Xilinx baremetal OS will use: volatile u32 *LocalAddr = (volatile u32 *)Addr;