Re: [XEN v3] xen/arm: Probe the entry point address of an uImage correctly

2022-12-20 Thread Ayan Kumar Halder
Hi Julien, I need a clarification. On 20/12/2022 12:51, Ayan Kumar Halder wrote: On 20/12/2022 12:14, Julien Grall wrote: Hi Ayan, Hi Julien, On 20/12/2022 10:44, Ayan Kumar Halder wrote: + +    /* + * Currently, we support uImage headers for uncompressed images only. + * Thus, i

Re: [XEN v3] xen/arm: Probe the entry point address of an uImage correctly

2022-12-20 Thread Ayan Kumar Halder
On 20/12/2022 12:14, Julien Grall wrote: Hi Ayan, Hi Julien, On 20/12/2022 10:44, Ayan Kumar Halder wrote: + +    /* + * Currently, we support uImage headers for uncompressed images only. + * Thus, it is valid for the load address and start address to be the + * same. This is

Re: [XEN v3] xen/arm: Probe the entry point address of an uImage correctly

2022-12-20 Thread Julien Grall
Hi Ayan, On 20/12/2022 10:44, Ayan Kumar Halder wrote: + +    /* + * Currently, we support uImage headers for uncompressed images only. + * Thus, it is valid for the load address and start address to be the + * same. This is consistent with the uboot behavior (Refer + * "case

Re: [XEN v3] xen/arm: Probe the entry point address of an uImage correctly

2022-12-20 Thread Ayan Kumar Halder
Hi Julien/Michal, On 20/12/2022 10:05, Julien Grall wrote: On 20/12/2022 09:44, Michal Orzel wrote: Hi Ayan, On 17/12/2022 20:38, Ayan Kumar Halder wrote: Currently, kernel_uimage_probe() does not set info->zimage.start. As a result, it contains the default value (ie 0). This causes, kernel_z

Re: [XEN v3] xen/arm: Probe the entry point address of an uImage correctly

2022-12-20 Thread Julien Grall
On 20/12/2022 09:44, Michal Orzel wrote: Hi Ayan, On 17/12/2022 20:38, Ayan Kumar Halder wrote: Currently, kernel_uimage_probe() does not set info->zimage.start. As a result, it contains the default value (ie 0). This causes, kernel_zimage_place() to treat the binary (contained within uImage) a

Re: [XEN v3] xen/arm: Probe the entry point address of an uImage correctly

2022-12-20 Thread Michal Orzel
Hi Ayan, On 17/12/2022 20:38, Ayan Kumar Halder wrote: > Currently, kernel_uimage_probe() does not set info->zimage.start. As a > result, it contains the default value (ie 0). This causes, > kernel_zimage_place() to treat the binary (contained within uImage) as > position independent executable. T

[XEN v3] xen/arm: Probe the entry point address of an uImage correctly

2022-12-17 Thread Ayan Kumar Halder
Currently, kernel_uimage_probe() does not set info->zimage.start. As a result, it contains the default value (ie 0). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach