Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-25 Thread Ayan Kumar Halder
Hi Stefano/Andre/All, Thanks for the feedback. On 22/01/2022 01:04, Stefano Stabellini wrote: On Thu, 20 Jan 2022, Ayan Kumar Halder wrote: At the moment, Xen is only handling data abort with valid syndrome (i.e. ISV=0). Unfortunately, this doesn't cover all the instructions a domain could

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-25 Thread Andre Przywara
On Mon, 24 Jan 2022 17:58:55 + Julien Grall wrote: Hi Julien, > Hi Andre, > > On 24/01/2022 14:36, Andre Przywara wrote: > > On Mon, 24 Jan 2022 12:07:42 + > >> Also, if an instruction is being modified by the guest (after it has > >> been loaded in the I cache), and if the guest

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-25 Thread Ayan Kumar Halder
Hi Jan/All, On 25/01/2022 08:55, Jan Beulich wrote: On 24.01.2022 19:41, Stefano Stabellini wrote: On Mon, 24 Jan 2022, Ayan Kumar Halder wrote: As for the patch, I will mention this issue (as a comment in the code) where we are loading the instruction from PC.

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-25 Thread Jan Beulich
On 24.01.2022 19:41, Stefano Stabellini wrote: > On Mon, 24 Jan 2022, Ayan Kumar Halder wrote: >> As for the patch, I will mention this issue (as a comment in the code) where >> we are loading the instruction from PC. Stefano/Julien/Bertrand/Volodymyr:- >> Does it look fine with you ? > > As this

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-24 Thread Stefano Stabellini
On Mon, 24 Jan 2022, Ayan Kumar Halder wrote: > Hi Andre, > > Thanks forn your comments. > > On 24/01/2022 14:36, Andre Przywara wrote: > > On Mon, 24 Jan 2022 12:07:42 + > > Ayan Kumar Halder wrote: > > > > Hi Ayan, > > > > > Many thanks for your feedback. I have one clarification :- > >

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-24 Thread Julien Grall
Hi, On 24/01/2022 17:27, Ayan Kumar Halder wrote: Thanks forn your comments. On 24/01/2022 14:36, Andre Przywara wrote: On Mon, 24 Jan 2022 12:07:42 + Ayan Kumar Halder wrote: Hi Ayan, Many thanks for your feedback. I have one clarification :- On 22/01/2022 01:30, Andre Przywara

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-24 Thread Julien Grall
Hi Andre, On 24/01/2022 14:36, Andre Przywara wrote: On Mon, 24 Jan 2022 12:07:42 + Also, if an instruction is being modified by the guest (after it has been loaded in the I cache), and if the guest does not invalidate the I cache + ISB, then this is a malicious behavior by the guest. Is

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-24 Thread Ayan Kumar Halder
Hi Andre, Thanks forn your comments. On 24/01/2022 14:36, Andre Przywara wrote: On Mon, 24 Jan 2022 12:07:42 + Ayan Kumar Halder wrote: Hi Ayan, Many thanks for your feedback. I have one clarification :- On 22/01/2022 01:30, Andre Przywara wrote: On Thu, 20 Jan 2022 21:55:27 +

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-24 Thread Andre Przywara
On Mon, 24 Jan 2022 12:07:42 + Ayan Kumar Halder wrote: Hi Ayan, > Many thanks for your feedback. I have one clarification :- > > On 22/01/2022 01:30, Andre Przywara wrote: > > On Thu, 20 Jan 2022 21:55:27 + > > Ayan Kumar Halder wrote: > > > > Hi, > > > >> At the moment, Xen is

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-24 Thread Ayan Kumar Halder
Hi Andre, Many thanks for your feedback. I have one clarification :- On 22/01/2022 01:30, Andre Przywara wrote: On Thu, 20 Jan 2022 21:55:27 + Ayan Kumar Halder wrote: Hi, At the moment, Xen is only handling data abort with valid syndrome (i.e. ISV=0). Unfortunately, this doesn't cover

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-21 Thread Andre Przywara
On Thu, 20 Jan 2022 21:55:27 + Ayan Kumar Halder wrote: Hi, > At the moment, Xen is only handling data abort with valid syndrome (i.e. > ISV=0). Unfortunately, this doesn't cover all the instructions a domain > could use to access MMIO regions. > > For instance, a baremetal OS can use any

Re: [XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-21 Thread Stefano Stabellini
On Thu, 20 Jan 2022, Ayan Kumar Halder wrote: > At the moment, Xen is only handling data abort with valid syndrome (i.e. > ISV=0). Unfortunately, this doesn't cover all the instructions a domain > could use to access MMIO regions. > > For instance, a baremetal OS can use any of the following

[XEN v3] xen/arm64: io: Decode ldr/str post-indexing instructions

2022-01-20 Thread Ayan Kumar Halder
At the moment, Xen is only handling data abort with valid syndrome (i.e. ISV=0). Unfortunately, this doesn't cover all the instructions a domain could use to access MMIO regions. For instance, a baremetal OS can use any of the following instructions, where x1 contains the address of the MMIO