Re: [Xen-devel] [PATCH] ALSA: xen-front: fix unintention integer overflow on left shifts

2019-06-30 Thread Oleksandr Andrushchenko
On 6/28/19 11:46 AM, Takashi Iwai wrote: On Thu, 27 Jun 2019 18:58:53 +0200, Colin King wrote: From: Colin Ian King Shifting the integer value 1 is evaluated using 32-bit arithmetic and then used in an expression that expects a 64-bit value, so there is potentially an integer overflow. Fix thi

Re: [Xen-devel] [PATCH] ALSA: xen-front: fix unintention integer overflow on left shifts

2019-06-28 Thread Takashi Iwai
On Thu, 27 Jun 2019 18:58:53 +0200, Colin King wrote: > > From: Colin Ian King > > Shifting the integer value 1 is evaluated using 32-bit > arithmetic and then used in an expression that expects a 64-bit > value, so there is potentially an integer overflow. Fix this > by using the BIT_ULL macro

[Xen-devel] [PATCH] ALSA: xen-front: fix unintention integer overflow on left shifts

2019-06-27 Thread Colin King
From: Colin Ian King Shifting the integer value 1 is evaluated using 32-bit arithmetic and then used in an expression that expects a 64-bit value, so there is potentially an integer overflow. Fix this by using the BIT_ULL macro to perform the shift. Addresses-Coverity: ("Unintentional integer ov