Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-25 Thread Wei Liu
On Tue, Jul 17, 2018 at 09:39:03AM +0100, Andrew Cooper wrote: > On 17/07/2018 07:57, Jan Beulich wrote: > On 16.07.18 at 18:56, wrote: > >> On 16/07/18 17:46, Jan Beulich wrote: > >>> For a reason that I can't explain, it is only the shim build that fails > >>> for me with an older gcc due

Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-18 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, July 18, 2018 5:39 PM > > >>> On 18.07.18 at 11:36, wrote: > > On Mon, Jul 16, 2018 at 10:46:11AM -0600, Jan Beulich wrote: > >> For a reason that I can't explain, it is only the shim build that fails > >> for me with an older gcc

Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-18 Thread Wei Liu
On Wed, Jul 18, 2018 at 03:39:20AM -0600, Jan Beulich wrote: > >>> On 18.07.18 at 11:36, wrote: > > On Mon, Jul 16, 2018 at 10:46:11AM -0600, Jan Beulich wrote: > >> For a reason that I can't explain, it is only the shim build that fails > >> for me with an older gcc due to the compiler not

Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-18 Thread Jan Beulich
>>> On 18.07.18 at 11:36, wrote: > On Mon, Jul 16, 2018 at 10:46:11AM -0600, Jan Beulich wrote: >> For a reason that I can't explain, it is only the shim build that fails >> for me with an older gcc due to the compiler not recognizing that >> apparently uninitialized variables aren't really

Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-18 Thread Wei Liu
On Mon, Jul 16, 2018 at 10:46:11AM -0600, Jan Beulich wrote: > For a reason that I can't explain, it is only the shim build that fails > for me with an older gcc due to the compiler not recognizing that > apparently uninitialized variables aren't really uninitialized. Pull out > the assignments

Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-18 Thread Jan Beulich
>>> On 16.07.18 at 18:56, wrote: > On 16/07/18 17:46, Jan Beulich wrote: >> For a reason that I can't explain, it is only the shim build that fails >> for me with an older gcc due to the compiler not recognizing that >> apparently uninitialized variables aren't really uninitialized. > > The only

Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-17 Thread Andrew Cooper
On 17/07/2018 07:57, Jan Beulich wrote: On 16.07.18 at 18:56, wrote: >> On 16/07/18 17:46, Jan Beulich wrote: >>> For a reason that I can't explain, it is only the shim build that fails >>> for me with an older gcc due to the compiler not recognizing that >>> apparently uninitialized

Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-17 Thread Jan Beulich
>>> On 16.07.18 at 18:56, wrote: > On 16/07/18 17:46, Jan Beulich wrote: >> For a reason that I can't explain, it is only the shim build that fails >> for me with an older gcc due to the compiler not recognizing that >> apparently uninitialized variables aren't really uninitialized. > > The only

Re: [Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-16 Thread Andrew Cooper
On 16/07/18 17:46, Jan Beulich wrote: > For a reason that I can't explain, it is only the shim build that fails > for me with an older gcc due to the compiler not recognizing that > apparently uninitialized variables aren't really uninitialized. The only thing that comes to mind is some

[Xen-devel] [PATCH] VMX: fix vmx_{find,del}_msr() build

2018-07-16 Thread Jan Beulich
For a reason that I can't explain, it is only the shim build that fails for me with an older gcc due to the compiler not recognizing that apparently uninitialized variables aren't really uninitialized. Pull out the assignments used by two of the three case blocks and make them initializers of the