Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-21 Thread Stefano Stabellini
On Thu, 21 Nov 2019, Julien Grall wrote: > > > As I said in a different sub-thread, I would reluctanly be ok to see > > > returning > > > 0 as long as we have add a warning for *every* access. Long-term, the > > > current > > > vGIC should really get killed. After speaking with Julien and reading

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-21 Thread Julien Grall
Hi Stefano, On 21/11/2019 18:50, Stefano Stabellini wrote: On Tue, 19 Nov 2019, Julien Grall wrote: Hi Andre, On 12/11/2019 12:46, Andre Przywara wrote: On Mon, 11 Nov 2019 11:01:07 -0800 (PST) Stefano Stabellini wrote: On Sat, 9 Nov 2019, Julien Grall wrote: On Sat, 9 Nov 2019, 04:27

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-21 Thread Stefano Stabellini
On Tue, 19 Nov 2019, Julien Grall wrote: > Hi Andre, > > On 12/11/2019 12:46, Andre Przywara wrote: > > On Mon, 11 Nov 2019 11:01:07 -0800 (PST) > > Stefano Stabellini wrote: > > > On Sat, 9 Nov 2019, Julien Grall wrote: > > > > On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, > > > > wrote: > > >

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-19 Thread Julien Grall
Hi Andre, On 12/11/2019 12:46, Andre Przywara wrote: On Mon, 11 Nov 2019 11:01:07 -0800 (PST) Stefano Stabellini wrote: On Sat, 9 Nov 2019, Julien Grall wrote: On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, wrote: On Thu, 7 Nov 2019, Peng Fan wrote: > The end should be

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-14 Thread Peng Fan
> Do you have a call stack trace for this? (XEN) d0v1: vGICD: unhandled read r1 offset 0x000324 (XEN) traps.c:1994:d0v1 HSR=0x93810006 pc=0x8000104f2bb4 gva=0x800010010324 gpa=0x0051a00324 [1.780564] Unhandled fault at 0x800010010324 [1.785771] Mem abort info: [

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-13 Thread Julien Grall
...@arm.com; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER > range > > Hi, > > Sorry for the formatting. > On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, sstabell...@kernel.org> wrote: > On Thu, 7 Nov 2019, Peng Fan

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-12 Thread Julien Grall
On Wed, 13 Nov 2019, 10:55 André Przywara, wrote: > On 13/11/2019 01:08, Julien Grall wrote: > > Hi, > > > On Tue, 12 Nov 2019, 04:01 Stefano Stabellini, > > wrote: > > > > On Sat, 9 Nov 2019, Julien Grall wrote: > > > On Sat, 9 Nov 2019, 04:27 Stefano

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-12 Thread André Przywara
On 13/11/2019 01:08, Julien Grall wrote: Hi, > On Tue, 12 Nov 2019, 04:01 Stefano Stabellini, > wrote: > > On Sat, 9 Nov 2019, Julien Grall wrote: > > On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, > mailto:sstabell...@kernel.org>> wrote: > >       

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-12 Thread Julien Grall
On Tue, 12 Nov 2019, 04:01 Stefano Stabellini, wrote: > On Sat, 9 Nov 2019, Julien Grall wrote: > > On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, > wrote: > > On Thu, 7 Nov 2019, Peng Fan wrote: > > > The end should be GICD_ISACTIVERN not GICD_ISACTIVER. > > > > > >

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-12 Thread Stefano Stabellini
t; Cc: Peng Fan ; Jürgen Groß ; > julien.gr...@arm.com; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range > > Hi, > > Sorry for the formatting. > On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, <mailto:sstabell...@kern

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-12 Thread Andre Przywara
On Mon, 11 Nov 2019 11:01:07 -0800 (PST) Stefano Stabellini wrote: Hi, > On Sat, 9 Nov 2019, Julien Grall wrote: > > On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, > > wrote: > > On Thu, 7 Nov 2019, Peng Fan wrote: > > > The end should be GICD_ISACTIVERN not GICD_ISACTIVER. > >

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-11 Thread Peng Fan
Hi Julien, Inline marked with [Peng Fan] From: Julien Grall Sent: 2019年11月9日 6:44 To: Stefano Stabellini ; Andre Przywara Cc: Peng Fan ; Jürgen Groß ; julien.gr...@arm.com; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range Hi, Sorry

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-11 Thread Stefano Stabellini
On Sat, 9 Nov 2019, Julien Grall wrote: > On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, wrote: > On Thu, 7 Nov 2019, Peng Fan wrote: > > The end should be GICD_ISACTIVERN not GICD_ISACTIVER. > > > > Signed-off-by: Peng Fan > > Reviewed-by: Stefano Stabellini > >

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-08 Thread Julien Grall
Hi, Sorry for the formatting. On Sat, 9 Nov 2019, 04:27 Stefano Stabellini, wrote: > On Thu, 7 Nov 2019, Peng Fan wrote: > > The end should be GICD_ISACTIVERN not GICD_ISACTIVER. > > > > Signed-off-by: Peng Fan > > Reviewed-by: Stefano Stabellini > To be honest, I am not sure the code is

Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-08 Thread Stefano Stabellini
On Thu, 7 Nov 2019, Peng Fan wrote: > The end should be GICD_ISACTIVERN not GICD_ISACTIVER. > > Signed-off-by: Peng Fan Reviewed-by: Stefano Stabellini Juergen, I think this fix should be in the release (and also backported to stable trees.) > --- > xen/arch/arm/vgic-v3.c | 2 +- > 1 file

[Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-06 Thread Peng Fan
The end should be GICD_ISACTIVERN not GICD_ISACTIVER. Signed-off-by: Peng Fan --- xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 422b94f902..e802f2055a 100644 --- a/xen/arch/arm/vgic-v3.c +++