Re: [Xen-devel] [PATCH] block: refactor duplicated macros

2020-03-10 Thread Song Liu
On Sun, Feb 23, 2020 at 8:58 AM Matteo Croce wrote: > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > Signed-off-by: Matteo Croce > --- > block/blk-lib.c

Re: [Xen-devel] [PATCH] block: refactor duplicated macros

2020-03-04 Thread Matteo Croce
On Wed, Mar 4, 2020 at 9:57 PM Dan Williams wrote: > > On Sun, Feb 23, 2020 at 9:04 AM Matteo Croce wrote: > > > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > > several times in different flavours across the whole tree. > > Define them just once in a common header.

Re: [Xen-devel] [PATCH] block: refactor duplicated macros

2020-03-04 Thread Dan Williams
On Sun, Feb 23, 2020 at 9:04 AM Matteo Croce wrote: > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > Signed-off-by: Matteo Croce > --- > block/blk-lib.c

Re: [Xen-devel] [PATCH] block: refactor duplicated macros

2020-03-04 Thread Ulf Hansson
On Sun, 23 Feb 2020 at 17:57, Matteo Croce wrote: > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > Signed-off-by: Matteo Croce For mmc: Acked-by: Ulf Hansson

[Xen-devel] [PATCH] block: refactor duplicated macros

2020-02-23 Thread Matteo Croce
The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined several times in different flavours across the whole tree. Define them just once in a common header. Signed-off-by: Matteo Croce --- block/blk-lib.c | 2 +- drivers/block/brd.c | 3 ---