Re: [Xen-devel] [PATCH] iommu: Eliminate an odd local variable

2019-01-22 Thread Andrii Anisov
Hello Jan, On 22.01.19 10:20, Jan Beulich wrote: What's excessive there? How come you alter the function's return value without saying why? The more that you make it potentially return success when there was an error. Ah, I've realized the difference. In unmap, for hardware domain, we will it

Re: [Xen-devel] [PATCH] iommu: Eliminate an odd local variable

2019-01-22 Thread Jan Beulich
>>> On 21.01.19 at 17:04, wrote: > Wipe out excessive lines from an iommu_unmap(), and align it with an > iommu_map() code. What's excessive there? How come you alter the function's return value without saying why? The more that you make it potentially return success when there was an error. Jan

[Xen-devel] [PATCH] iommu: Eliminate an odd local variable

2019-01-21 Thread Andrii Anisov
From: Andrii Anisov Wipe out excessive lines from an iommu_unmap(), and align it with an iommu_map() code. Signed-off-by: Andrii Anisov --- xen/drivers/passthrough/iommu.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers