Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] tools/libxl: Fix assertion
failure when trying to build a nested-virt PVH domain"):
> On Fri, Jan 26, 2018 at 07:23:52PM +, Andrew Cooper wrote:
...
> > I'm not the check is overly old to begin with. We
On Fri, Jan 26, 2018 at 07:23:52PM +, Andrew Cooper wrote:
> On 26/01/18 19:11, Ian Jackson wrote:
> > Andrew Cooper writes ("[PATCH] tools/libxl: Fix assertion failure when
> > trying to build a nested-virt PVH domain"):
> >> xl: libxl.c:339: libxl_defbool_val: Assertion
> >>
On 26/01/18 19:11, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH] tools/libxl: Fix assertion failure when trying
> to build a nested-virt PVH domain"):
>> xl: libxl.c:339: libxl_defbool_val: Assertion
>> `!libxl_defbool_is_default(db)' failed.
>>
>> This happens because
Andrew Cooper writes ("[PATCH] tools/libxl: Fix assertion failure when trying
to build a nested-virt PVH domain"):
> xl: libxl.c:339: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)'
> failed.
>
> This happens because initiate_domain_create() checks for type != HVM, then
> pokes at
xl: libxl.c:339: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)'
failed.
This happens because initiate_domain_create() checks for type != HVM, then
pokes at the hvm union. Check for == HVM instead so the union access is
correctly guarded.
Signed-off-by: Andrew Cooper
