[Xen-devel] [PATCH] tools: fix dependency for ipxe and rombios

2018-07-17 Thread Wei Liu
It appears that the test in 01d631028 for ipxe's dependency on rombios is not good enough. Configuring with --disable-rombios doesn't disable ipxe. Fix it by testing the dependency in AC_ARG_ENABLE and AC_ARG_WITH at the same time. We intentionally omit help string in AC_ARG_ENABLE so that it is n

Re: [Xen-devel] [PATCH] tools: fix dependency for ipxe and rombios

2018-07-17 Thread Ian Jackson
Wei Liu writes ("[PATCH] tools: fix dependency for ipxe and rombios"): > It appears that the test in 01d631028 for ipxe's dependency on rombios > is not good enough. Configuring with --disable-rombios doesn't disable > ipxe. > > Fix it by testing the dependency in AC_ARG_ENABLE and AC_ARG_WITH at

Re: [Xen-devel] [PATCH] tools: fix dependency for ipxe and rombios

2018-07-17 Thread Wei Liu
On Tue, Jul 17, 2018 at 11:18:59AM +0100, Ian Jackson wrote: > So I'm sorry to say that I think the answer is to revert 01d631028a02 > and to replace it with a patch which introduces >--with-ipxe=/PATH >--with-ipxe like --enable-ipxe, but also sets path to "" >--without-ipxe

Re: [Xen-devel] [PATCH] tools: fix dependency for ipxe and rombios

2018-07-17 Thread Wei Liu
On Tue, Jul 17, 2018 at 11:47:41AM +0100, Wei Liu wrote: > On Tue, Jul 17, 2018 at 11:18:59AM +0100, Ian Jackson wrote: > > So I'm sorry to say that I think the answer is to revert 01d631028a02 > > and to replace it with a patch which introduces > >--with-ipxe=/PATH > >--with-ipxe

Re: [Xen-devel] [PATCH] tools: fix dependency for ipxe and rombios

2018-07-18 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] tools: fix dependency for ipxe and rombios"): > On Tue, Jul 17, 2018 at 11:47:41AM +0100, Wei Liu wrote: > > On Tue, Jul 17, 2018 at 11:18:59AM +0100, Ian Jackson wrote: > > > So I'm sorry to say that I think the answer is to revert 01d631028a02 > > > and to replace it

Re: [Xen-devel] [PATCH] tools: fix dependency for ipxe and rombios

2018-07-18 Thread Wei Liu
On Wed, Jul 18, 2018 at 11:09:39AM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH] tools: fix dependency for ipxe and rombios"): > > On Tue, Jul 17, 2018 at 11:47:41AM +0100, Wei Liu wrote: > > > On Tue, Jul 17, 2018 at 11:18:59AM +0100, Ian Jackson wrote: > > > > So I'm sorry to say that