Re: [Xen-devel] [PATCH] x86/ptwr: Misc cleanup to ptwr_emulated_update()

2018-08-13 Thread Jan Beulich
>>> On 10.08.18 at 20:27, wrote: > On Fri, Aug 10, 2018 at 06:49:12PM +0100, Andrew Cooper wrote: >> All but one user wants mfn as mfn_t, so switch its type. offset is only ever >> used when multipled by 8, so fold that into its initial calculation. Fold >> all >> the pointer arithmic on pl1e

Re: [Xen-devel] [PATCH] x86/ptwr: Misc cleanup to ptwr_emulated_update()

2018-08-10 Thread Wei Liu
On Fri, Aug 10, 2018 at 06:49:12PM +0100, Andrew Cooper wrote: > All but one user wants mfn as mfn_t, so switch its type. offset is only ever > used when multipled by 8, so fold that into its initial calculation. Fold all > the pointer arithmic on pl1e together, to avoid needless casts. > > No

[Xen-devel] [PATCH] x86/ptwr: Misc cleanup to ptwr_emulated_update()

2018-08-10 Thread Andrew Cooper
All but one user wants mfn as mfn_t, so switch its type. offset is only ever used when multipled by 8, so fold that into its initial calculation. Fold all the pointer arithmic on pl1e together, to avoid needless casts. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich