Re: [Xen-devel] [PATCH] x86/vPMU: don't blindly assume IA32_PERF_CAPABILITIES MSR exists

2020-02-26 Thread Chen, Farrah
I applied this patch to Xen and retested, Xen on KVM booted up successfully, thanks a lot. Thanks, Fan -Original Message- From: Andrew Cooper Sent: Wednesday, February 26, 2020 6:56 PM To: Jan Beulich ; Roger Pau Monné Cc: xen-devel@lists.xenproject.org; Chen, Farrah ; Hao, Xudong ;

Re: [Xen-devel] [PATCH] x86/vPMU: don't blindly assume IA32_PERF_CAPABILITIES MSR exists

2020-02-26 Thread Andrew Cooper
On 26/02/2020 10:39, Jan Beulich wrote: > On 26.02.2020 11:09, Roger Pau Monné wrote: >> On Wed, Feb 26, 2020 at 10:19:19AM +0100, Jan Beulich wrote: >>> Just like VMX'es lbr_tsx_fixup_check() the respective CPUID bit should >>> be consulted first. >>> >>> Reported-by: Farrah Chen >>>

Re: [Xen-devel] [PATCH] x86/vPMU: don't blindly assume IA32_PERF_CAPABILITIES MSR exists

2020-02-26 Thread Jan Beulich
On 26.02.2020 11:09, Roger Pau Monné wrote: > On Wed, Feb 26, 2020 at 10:19:19AM +0100, Jan Beulich wrote: >> Just like VMX'es lbr_tsx_fixup_check() the respective CPUID bit should >> be consulted first. >> >> Reported-by: Farrah Chen >> Signed-off-by: Jan Beulich >> >> ---

Re: [Xen-devel] [PATCH] x86/vPMU: don't blindly assume IA32_PERF_CAPABILITIES MSR exists

2020-02-26 Thread Andrew Cooper
On 26/02/2020 09:19, Jan Beulich wrote: > Just like VMX'es lbr_tsx_fixup_check() the respective CPUID bit should > be consulted first. > > Reported-by: Farrah Chen > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH] x86/vPMU: don't blindly assume IA32_PERF_CAPABILITIES MSR exists

2020-02-26 Thread Roger Pau Monné
On Wed, Feb 26, 2020 at 10:19:19AM +0100, Jan Beulich wrote: > Just like VMX'es lbr_tsx_fixup_check() the respective CPUID bit should > be consulted first. > > Reported-by: Farrah Chen > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/cpu/vpmu_intel.c > +++ b/xen/arch/x86/cpu/vpmu_intel.c >

[Xen-devel] [PATCH] x86/vPMU: don't blindly assume IA32_PERF_CAPABILITIES MSR exists

2020-02-26 Thread Jan Beulich
Just like VMX'es lbr_tsx_fixup_check() the respective CPUID bit should be consulted first. Reported-by: Farrah Chen Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -900,7 +900,6 @@ int vmx_vpmu_initialise(struct vcpu *v) int __init