Re: [Xen-devel] [PATCH] x86/xen: Clear user %gs before updating segment descriptors

2018-12-10 Thread Boris Ostrovsky
On 12/7/18 6:15 PM, David Woodhouse wrote: > > - load_TLS_descriptor(t, cpu, 0); > - load_TLS_descriptor(t, cpu, 1); > - load_TLS_descriptor(t, cpu, 2); > + load_TLS_descriptor(t, cpu, 0, flush_gs); > + load_TLS_descriptor(t, cpu, 1, flush_gs); > + load_TLS_descriptor(t,

Re: [Xen-devel] [PATCH] x86/xen: Clear user %gs before updating segment descriptors

2018-12-07 Thread Andy Lutomirski
On Fri, Dec 7, 2018 at 3:15 PM David Woodhouse wrote: > > During a context switch, if clearing a descriptor which is currently > referenced by the old process's user %gs, if Xen preempts the vCPU > before %gs is set for the new process, a fault may occur. > > This fault actually seems to be

[Xen-devel] [PATCH] x86/xen: Clear user %gs before updating segment descriptors

2018-12-07 Thread David Woodhouse
During a context switch, if clearing a descriptor which is currently referenced by the old process's user %gs, if Xen preempts the vCPU before %gs is set for the new process, a fault may occur. This fault actually seems to be fairly harmless; xen_failsafe_callback will just return to the

[Xen-devel] [PATCH] x86/xen: Clear user %gs before updating segment descriptors

2018-12-07 Thread David Woodhouse
During a context switch, if clearing a descriptor which is currently referenced by the old process's user %gs, if Xen preempts the vCPU before %gs is set for the new process, a fault may occur. This fault actually seems to be fairly harmless; xen_failsafe_callback will just return to the