[Xen-devel] [PATCH] x86: fix return value checks of set_guest_{machinecheck, nmi}_trapbounce

2018-05-02 Thread Jan Beulich
Commit 0142064421 ("x86/traps: move set_guest_{machine,nmi}_trapbounce") converted the functions' return types from int to bool without also correcting the checks in assembly code: The ABI does not guarantee sub- 32-bit return values to be promoted to 32 bits. Take the liberty and also adjust the

Re: [Xen-devel] [PATCH] x86: fix return value checks of set_guest_{machinecheck, nmi}_trapbounce

2018-05-02 Thread Andrew Cooper
On 02/05/18 10:02, Jan Beulich wrote: > Commit 0142064421 ("x86/traps: move set_guest_{machine,nmi}_trapbounce") > converted the functions' return types from int to bool without also > correcting the checks in assembly code: The ABI does not guarantee sub- > 32-bit return values to be promoted to 3

Re: [Xen-devel] [PATCH] x86: fix return value checks of set_guest_{machinecheck, nmi}_trapbounce

2018-05-02 Thread Juergen Gross
On 02/05/18 11:02, Jan Beulich wrote: > Commit 0142064421 ("x86/traps: move set_guest_{machine,nmi}_trapbounce") > converted the functions' return types from int to bool without also > correcting the checks in assembly code: The ABI does not guarantee sub- > 32-bit return values to be promoted to 3