Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

2018-09-11 Thread Dario Faggioli
On Thu, 2018-08-30 at 16:31 +0100, Andrew Cooper wrote: > There original reason for this patch was to fix a livepatching > problem; > unnecesserily large livepatchs due to the use of __LINE__. > > A second problem is one of debugability. A number of domain_crash() > invocations have no logging at

Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

2018-09-03 Thread Razvan Cojocaru
On 8/30/18 6:31 PM, Andrew Cooper wrote: > There original reason for this patch was to fix a livepatching problem; > unnecesserily large livepatchs due to the use of __LINE__. > > A second problem is one of debugability. A number of domain_crash() > invocations have no logging at all, and number

Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

2018-08-31 Thread Jan Beulich
>>> On 31.08.18 at 15:48, wrote: > On 31/08/18 09:39, Jan Beulich wrote: > On 30.08.18 at 17:31, wrote: >>> @@ -2686,17 +2678,22 @@ static void *hvm_map_entry(unsigned long va, bool_t >>> *writable) >>> pfec = PFEC_page_present; >>> gfn = paging_gva_to_gfn(current, va, &pfec); >>>

Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

2018-08-31 Thread Andrew Cooper
On 31/08/18 09:39, Jan Beulich wrote: On 30.08.18 at 17:31, wrote: >> --- a/xen/arch/arm/mem_access.c >> +++ b/xen/arch/arm/mem_access.c >> @@ -293,12 +293,7 @@ bool p2m_mem_access_check(paddr_t gpa, vaddr_t gla, >> const struct npfec npfec) >> { >> /* No listener */ >>

Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

2018-08-31 Thread Jan Beulich
>>> On 30.08.18 at 17:31, wrote: > --- a/xen/arch/arm/mem_access.c > +++ b/xen/arch/arm/mem_access.c > @@ -293,12 +293,7 @@ bool p2m_mem_access_check(paddr_t gpa, vaddr_t gla, > const struct npfec npfec) > { > /* No listener */ > if ( p2m->access_required ) > -{ > -

Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

2018-08-30 Thread Andrew Cooper
On 30/08/18 17:01, Razvan Cojocaru wrote: > On 8/30/18 6:31 PM, Andrew Cooper wrote: >> There original reason for this patch was to fix a livepatching problem; >> unnecesserily large livepatchs due to the use of __LINE__. >> >> A second problem is one of debugability. A number of domain_crash() >>

Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

2018-08-30 Thread Razvan Cojocaru
On 8/30/18 6:31 PM, Andrew Cooper wrote: > There original reason for this patch was to fix a livepatching problem; > unnecesserily large livepatchs due to the use of __LINE__. > > A second problem is one of debugability. A number of domain_crash() > invocations have no logging at all, and number

[Xen-devel] [PATCH] xen: Improvements to domain_crash()

2018-08-30 Thread Andrew Cooper
There original reason for this patch was to fix a livepatching problem; unnecesserily large livepatchs due to the use of __LINE__. A second problem is one of debugability. A number of domain_crash() invocations have no logging at all, and number of others only have logging when compiled with a de