Re: [Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-28 Thread Wei Liu
On Tue, Aug 28, 2018 at 03:12:32PM +0100, Andrew Cooper wrote: > On 24/08/18 13:16, Paul Durrant wrote: > > diff --git a/tools/libs/foreignmemory/linux.c > > b/tools/libs/foreignmemory/linux.c > > index 3686cf41e0..0368aa09f4 100644 > > --- a/tools/libs/foreignmemory/linux.c > > +++

Re: [Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-28 Thread Andrew Cooper
On 24/08/18 13:16, Paul Durrant wrote: > diff --git a/tools/libs/foreignmemory/linux.c > b/tools/libs/foreignmemory/linux.c > index 3686cf41e0..0368aa09f4 100644 > --- a/tools/libs/foreignmemory/linux.c > +++ b/tools/libs/foreignmemory/linux.c > @@ -53,6 +53,23 @@ int

Re: [Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-27 Thread Wei Liu
On Mon, Aug 27, 2018 at 03:04:55AM -0600, Jan Beulich wrote: > >>> On 24.08.18 at 14:16, wrote: > > Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY > > for unimplemented IOCTLs") will return -EINVAL rather than the conventional > > -ENOTTY for unimplemented codes. This

Re: [Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-27 Thread Jan Beulich
>>> On 24.08.18 at 14:16, wrote: > Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY > for unimplemented IOCTLs") will return -EINVAL rather than the conventional > -ENOTTY for unimplemented codes. This breaks the error path in > libxenforeignmemory resource mapping, which

Re: [Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-24 Thread Ian Jackson
Paul Durrant writes ("[PATCH] xenforeignmemory: work around bug in older privcmd"): > Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY > for unimplemented IOCTLs") will return -EINVAL rather than the conventional > -ENOTTY for unimplemented codes. This breaks the error path

Re: [Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 01:16:26PM +0100, Paul Durrant wrote: > Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY > for unimplemented IOCTLs") will return -EINVAL rather than the conventional > -ENOTTY for unimplemented codes. This breaks the error path in >

[Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-24 Thread Paul Durrant
Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY for unimplemented IOCTLs") will return -EINVAL rather than the conventional -ENOTTY for unimplemented codes. This breaks the error path in libxenforeignmemory resource mapping, which only translates ENOTTY into EOPNOTSUPP to