Re: [Xen-devel] [PATCH 02/10] tools/libxc: Simplify xc_get_static_cpu_featuremask()

2020-02-27 Thread Andrew Cooper
On 27/02/2020 09:55, Andrew Cooper wrote: >>> +BUILD_BUG_ON(ARRAY_SIZE(masks[0]) != FEATURESET_NR_ENTRIES); >> Isn't this quite pointless with the now changed definition of >> the array? > I'd need to double check Double check says it isn't necessary.  I'll drop. ~Andrew

Re: [Xen-devel] [PATCH 02/10] tools/libxc: Simplify xc_get_static_cpu_featuremask()

2020-02-27 Thread Andrew Cooper
On 27/02/2020 07:47, Jan Beulich wrote: > On 26.02.2020 21:22, Andrew Cooper wrote: >> Drop XC_FEATUREMASK_DEEP_FEATURES. It isn't used by any callers, and unlike >> the other static masks, won't be of interest to anyone without other pieces >> of >> cpuid-autogen.h >> >> In

Re: [Xen-devel] [PATCH 02/10] tools/libxc: Simplify xc_get_static_cpu_featuremask()

2020-02-26 Thread Jan Beulich
On 26.02.2020 21:22, Andrew Cooper wrote: > Drop XC_FEATUREMASK_DEEP_FEATURES. It isn't used by any callers, and unlike > the other static masks, won't be of interest to anyone without other pieces of > cpuid-autogen.h > > In xc_get_static_cpu_featuremask(), use a 2d array instead of

[Xen-devel] [PATCH 02/10] tools/libxc: Simplify xc_get_static_cpu_featuremask()

2020-02-26 Thread Andrew Cooper
Drop XC_FEATUREMASK_DEEP_FEATURES. It isn't used by any callers, and unlike the other static masks, won't be of interest to anyone without other pieces of cpuid-autogen.h In xc_get_static_cpu_featuremask(), use a 2d array instead of individually named variables, and drop the switch statement