Re: [Xen-devel] [PATCH 03/10] x86/gen-cpuid: Rework internal logic to ease future changes

2020-02-27 Thread Andrew Cooper
On 27/02/2020 07:57, Jan Beulich wrote: > On 26.02.2020 21:22, Andrew Cooper wrote: >> Better split the logic between parse/calculate/write. Collect the feature >> comment by their comment character, and perform the accumulation operations >> in >> crunch_numbers(). > Would you mind saying

Re: [Xen-devel] [PATCH 03/10] x86/gen-cpuid: Rework internal logic to ease future changes

2020-02-26 Thread Jan Beulich
On 26.02.2020 21:22, Andrew Cooper wrote: > Better split the logic between parse/calculate/write. Collect the feature > comment by their comment character, and perform the accumulation operations in > crunch_numbers(). Would you mind saying "character(s)" here, as there are items with multiple

[Xen-devel] [PATCH 03/10] x86/gen-cpuid: Rework internal logic to ease future changes

2020-02-26 Thread Andrew Cooper
Better split the logic between parse/calculate/write. Collect the feature comment by their comment character, and perform the accumulation operations in crunch_numbers(). Avoid rendering the featuresets to C uint32_t's in crunch_numbers(), and instead do this in write_results(). Update