Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-31 Thread Julien Grall
(sorry for the formatting) On Thu, 31 May 2018, 22:00 Stefano Stabellini, wrote: > On Thu, 31 May 2018, Julien Grall wrote: > > Hi, > > > > On 30/05/18 21:10, Stefano Stabellini wrote: > > > On Wed, 30 May 2018, Julien Grall wrote: > > > > On 05/29/2018 11:34 PM, Stefano Stabellini wrote: > > >

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-31 Thread Stefano Stabellini
On Thu, 31 May 2018, Julien Grall wrote: > Hi, > > On 30/05/18 21:10, Stefano Stabellini wrote: > > On Wed, 30 May 2018, Julien Grall wrote: > > > On 05/29/2018 11:34 PM, Stefano Stabellini wrote: > > > > On Tue, 29 May 2018, Julien Grall wrote: > > > > > On 25/05/18 21:51, Stefano Stabellini wrot

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-31 Thread Julien Grall
Hi, On 30/05/18 21:10, Stefano Stabellini wrote: On Wed, 30 May 2018, Julien Grall wrote: On 05/29/2018 11:34 PM, Stefano Stabellini wrote: On Tue, 29 May 2018, Julien Grall wrote: On 25/05/18 21:51, Stefano Stabellini wrote: On Thu, 24 May 2018, Julien Grall wrote: On 23/05/18 23:34, Stefa

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-30 Thread Stefano Stabellini
On Wed, 30 May 2018, Julien Grall wrote: > On 05/29/2018 11:34 PM, Stefano Stabellini wrote: > > On Tue, 29 May 2018, Julien Grall wrote: > > > On 25/05/18 21:51, Stefano Stabellini wrote: > > > > On Thu, 24 May 2018, Julien Grall wrote: > > > > > On 23/05/18 23:34, Stefano Stabellini wrote: > > >

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-30 Thread Julien Grall
Hi Stefano, On 05/29/2018 11:34 PM, Stefano Stabellini wrote: On Tue, 29 May 2018, Julien Grall wrote: On 25/05/18 21:51, Stefano Stabellini wrote: On Thu, 24 May 2018, Julien Grall wrote: On 23/05/18 23:34, Stefano Stabellini wrote: On Tue, 22 May 2018, Julien Grall arm_smccc_1_1_smc(

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-29 Thread Stefano Stabellini
On Tue, 29 May 2018, Julien Grall wrote: > On 25/05/18 21:51, Stefano Stabellini wrote: > > On Thu, 24 May 2018, Julien Grall wrote: > > > On 23/05/18 23:34, Stefano Stabellini wrote: > > > > On Tue, 22 May 2018, Julien Grall > > > > arm_smccc_1_1_smc(ARM_SMCCC_ARCH_FEATURES_FID, > > > > >

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-29 Thread Julien Grall
On 25/05/18 21:51, Stefano Stabellini wrote: On Thu, 24 May 2018, Julien Grall wrote: On 23/05/18 23:34, Stefano Stabellini wrote: On Tue, 22 May 2018, Julien Grall arm_smccc_1_1_smc(ARM_SMCCC_ARCH_FEATURES_FID, ARM_SMCCC_ARCH_WORKAROUND_2_FID, &res); -

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-29 Thread Julien Grall
Hi Stefano, On 05/24/2018 01:48 AM, Stefano Stabellini wrote: On Wed, 23 May 2018, Stefano Stabellini wrote: On Tue, 22 May 2018, Julien Grall wrote: + +default: +ASSERT_UNREACHABLE(); +return false; +} + +switch ( ssbd_state ) +{ +case ARM_SSBD_FORCE_DISABL

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-25 Thread Stefano Stabellini
On Thu, 24 May 2018, Julien Grall wrote: > Hi Stefano, > > On 23/05/18 23:34, Stefano Stabellini wrote: > > On Tue, 22 May 2018, Julien Grall wrote: > > > On a system where the firmware implements ARCH_WORKAROUND_2, it may be > > > useful to either permanently enable or disable the workaround for

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-24 Thread Julien Grall
Hi Stefano, On 24/05/18 00:23, Stefano Stabellini wrote: On Tue, 22 May 2018, Julien Grall wrote: +extern enum ssbd_state ssbd_state; + +static inline enum ssbd_state get_ssbd_state(void) +{ +return ssbd_state; +} + DECLARE_PER_CPU(register_t, ssbd_callback_required); static inline b

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-24 Thread Julien Grall
Hi Stefano, On 23/05/18 23:34, Stefano Stabellini wrote: On Tue, 22 May 2018, Julien Grall wrote: On a system where the firmware implements ARCH_WORKAROUND_2, it may be useful to either permanently enable or disable the workaround for cases where the user decides that they'd rather not get a tr

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-23 Thread Stefano Stabellini
On Wed, 23 May 2018, Stefano Stabellini wrote: > On Tue, 22 May 2018, Julien Grall wrote: > > On a system where the firmware implements ARCH_WORKAROUND_2, it may be > > useful to either permanently enable or disable the workaround for cases > > where the user decides that they'd rather not get a tr

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-23 Thread Stefano Stabellini
On Tue, 22 May 2018, Julien Grall wrote: > +extern enum ssbd_state ssbd_state; > + > +static inline enum ssbd_state get_ssbd_state(void) > +{ > +return ssbd_state; > +} > + > DECLARE_PER_CPU(register_t, ssbd_callback_required); > > static inline bool cpu_require_ssbd_mitigation(void) > @@ -

Re: [Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-23 Thread Stefano Stabellini
On Tue, 22 May 2018, Julien Grall wrote: > On a system where the firmware implements ARCH_WORKAROUND_2, it may be > useful to either permanently enable or disable the workaround for cases > where the user decides that they'd rather not get a trap overhead, and > keep the mitigation permanently on o

[Xen-devel] [PATCH 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-05-22 Thread Julien Grall
On a system where the firmware implements ARCH_WORKAROUND_2, it may be useful to either permanently enable or disable the workaround for cases where the user decides that they'd rather not get a trap overhead, and keep the mitigation permanently on or off instead of switching it on exception entry/