Re: [Xen-devel] [PATCH 06/24] golang/xenlight: re-name Bitmap marshaling functions

2019-11-14 Thread George Dunlap
On 11/13/19 8:53 PM, Nick Rosbrook wrote: >> Any particular reason to use `cslice` here rather than `mapslice` (or >> vice versa)? >> >> Not a big deal, but since they're of the came element in the C struct, >> it seems like it would be better to give them the same name. (Don't >> have a strong

Re: [Xen-devel] [PATCH 06/24] golang/xenlight: re-name Bitmap marshaling functions

2019-11-13 Thread Nick Rosbrook
> Any particular reason to use `cslice` here rather than `mapslice` (or > vice versa)? > > Not a big deal, but since they're of the came element in the C struct, > it seems like it would be better to give them the same name. (Don't > have a strong opinion on which one). IIRC, I found the name

Re: [Xen-devel] [PATCH 06/24] golang/xenlight: re-name Bitmap marshaling functions

2019-11-13 Thread George Dunlap
On 10/7/19 4:12 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Re-name and modify signature of toGo function to fromC. The reason for > using 'fromC' rather than 'toGo' is that it is not a good idea to define > methods on the C types. Also, add error return type to Bitmap's toC function. >

[Xen-devel] [PATCH 06/24] golang/xenlight: re-name Bitmap marshaling functions

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Re-name and modify signature of toGo function to fromC. The reason for using 'fromC' rather than 'toGo' is that it is not a good idea to define methods on the C types. Also, add error return type to Bitmap's toC function. Finally, as code-cleanup, re-organize the Bitmap