Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise"): > > On 30 Oct 2018, at 16:50, Ian Jackson wrote: > > I'm not much of an ocaml programmer but this seems like it has no > > overall functional change ? &g

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Christian Lindig
> On 30 Oct 2018, at 16:50, Ian Jackson wrote: > > I'm not much of an ocaml programmer but this seems like it has no > overall functional change ? > > I take it that ignore is the trivial function with type ('a -> unit). That is correct. Except that types now reflect more accurately what is

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("[Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise"): > The type of Xsraw.sync is made more precise: > > from val sync : (Xenbus.Xb.t -> 'a) -> con -> string > to val sync : (Xenbus.Xb.t -> unit) ->

[Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Christian Lindig
The type of Xsraw.sync is made more precise: from val sync : (Xenbus.Xb.t -> 'a) -> con -> string to val sync : (Xenbus.Xb.t -> unit) -> con -> string The first argument is enforced to return unit rather than a value that is not used anyway. Signed-off-by: Christian Lindig ---