[Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures

2019-11-21 Thread Andrew Cooper
The VT-x task switch handler adds inst_len to rip before calling hvm_task_switch(). This causes early faults to be delivered to the guest with trap semantics, and break restartibility. Instead, pass the instruction length into hvm_task_switch() and write it into the outgoing tss only, leaving rip

Re: [Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures

2019-11-22 Thread Roger Pau Monné
On Thu, Nov 21, 2019 at 10:15:50PM +, Andrew Cooper wrote: > The VT-x task switch handler adds inst_len to rip before calling > hvm_task_switch(). This causes early faults to be delivered to the guest with By early faults you mean faults injected by hvm_task_switch itself for example? > trap

Re: [Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures

2019-11-22 Thread Andrew Cooper
On 22/11/2019 12:37, Roger Pau Monné wrote: > On Thu, Nov 21, 2019 at 10:15:50PM +, Andrew Cooper wrote: >> The VT-x task switch handler adds inst_len to rip before calling >> hvm_task_switch(). This causes early faults to be delivered to the guest >> with > By early faults you mean faults in

Re: [Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures

2019-11-22 Thread Jan Beulich
On 22.11.2019 13:37, Roger Pau Monné wrote: > On Thu, Nov 21, 2019 at 10:15:50PM +, Andrew Cooper wrote: >> The VT-x task switch handler adds inst_len to rip before calling >> hvm_task_switch(). This causes early faults to be delivered to the guest >> with >> trap semantics, and break restar

Re: [Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures

2019-11-22 Thread Andrew Cooper
On 22/11/2019 13:08, Jan Beulich wrote: > On 22.11.2019 13:37, Roger Pau Monné wrote: >> On Thu, Nov 21, 2019 at 10:15:50PM +, Andrew Cooper wrote: >>> The VT-x task switch handler adds inst_len to rip before calling >>> hvm_task_switch(). This causes early faults to be delivered to the guest

Re: [Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures

2019-11-22 Thread Jan Beulich
On 22.11.2019 14:12, Andrew Cooper wrote: > On 22/11/2019 13:08, Jan Beulich wrote: >> On 22.11.2019 13:37, Roger Pau Monné wrote: >>> On Thu, Nov 21, 2019 at 10:15:50PM +, Andrew Cooper wrote: The VT-x task switch handler adds inst_len to rip before calling hvm_task_switch(). This

Re: [Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures

2019-11-22 Thread Andrew Cooper
On 22/11/2019 13:39, Jan Beulich wrote: > On 22.11.2019 14:12, Andrew Cooper wrote: >> On 22/11/2019 13:08, Jan Beulich wrote: >>> On 22.11.2019 13:37, Roger Pau Monné wrote: On Thu, Nov 21, 2019 at 10:15:50PM +, Andrew Cooper wrote: > The VT-x task switch handler adds inst_len to rip

Re: [Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures

2019-11-25 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Friday, November 22, 2019 6:16 AM > > The VT-x task switch handler adds inst_len to rip before calling > hvm_task_switch(). This causes early faults to be delivered to the guest > with > trap semantics, and break restartibility. >