Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Andrii Anisov
Hello George, On 11.09.18 18:54, George Dunlap wrote: FYI, I never use xentrace_format; as far as I'm concerned it's been made obsolete by xenalyze, and if it were up to me I'd remove it from the tree. Lots of people seem to find it useful, so I review patches. But I really care very little ab

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Andrii Anisov
Hello Dario, On 12.09.18 10:42, Dario Faggioli wrote: Sorry, I'm not sure I'm getting this properly. When you say "with the current formula", do you mean before or after this series? I did mean the formula existing before this series. IAC, changing the default format file that we ship so tha

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Dario Faggioli
On Tue, 2018-09-11 at 16:54 +0100, George Dunlap wrote: > On 09/11/2018 04:19 PM, Andrii Anisov wrote: > > > > On 11.09.18 13:44, George Dunlap wrote: > > > What I do in xenalyze is to have the timestamps in seconds, but > > > always > > > print down to the nanosecond. (For this I actually break

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-11 Thread George Dunlap
On 09/11/2018 04:19 PM, Andrii Anisov wrote: > > On 11.09.18 13:44, George Dunlap wrote: >> What I do in xenalyze is to have the timestamps in seconds, but always >> print down to the nanosecond.  (For this I actually break cpu cycles >> into s and ns separately, and then print "%u.%09u".) > Here,

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-11 Thread Andrii Anisov
On 11.09.18 13:44, George Dunlap wrote: What I do in xenalyze is to have the timestamps in seconds, but always print down to the nanosecond. (For this I actually break cpu cycles into s and ns separately, and then print "%u.%09u".) Here, we can have the same. With the 0current formula in xentr

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-11 Thread George Dunlap
On 09/11/2018 11:44 AM, George Dunlap wrote: > On 09/11/2018 11:32 AM, Andrii Anisov wrote: >> Hello George, >> >> >> On 11.09.18 13:15, George Dunlap wrote:   if mhz: -    tsc = tsc / (mhz*100.0) +    tsc = tsc * 1000.0 / mhz >>> Why do you prefer this? >

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-11 Thread George Dunlap
On 09/11/2018 11:32 AM, Andrii Anisov wrote: > Hello George, > > > On 11.09.18 13:15, George Dunlap wrote: >>>   if mhz: >>> -    tsc = tsc / (mhz*100.0) >>> +    tsc = tsc * 1000.0 / mhz >> Why do you prefer this? > I'm playing with scheduling from one hand, so time s

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-11 Thread Andrii Anisov
Hello George, On 11.09.18 13:15, George Dunlap wrote: if mhz: -tsc = tsc / (mhz*100.0) +tsc = tsc * 1000.0 / mhz Why do you prefer this? I'm playing with scheduling from one hand, so time stamps in seconds does not give understanding about what's going on

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-11 Thread George Dunlap
On 09/10/2018 05:41 PM, Andrii Anisov wrote: > From: Andrii Anisov The title here makes it seem like you're introducing new functionality, when in fact you're just documenting and tweaking existing functionality. The description should be something like: --- xentrace_format: Document -c option

[Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-10 Thread Andrii Anisov
From: Andrii Anisov Signed-off-by: Andrii Anisov --- tools/xentrace/xentrace_format | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/xentrace/xentrace_format b/tools/xentrace/xentrace_format index 5ff85ae..323d0c2 100644 --- a/tools/xentrace/xentrace_format +++