Re: [Xen-devel] [PATCH 1/6] x86/mm: Use mfn_eq()/mfn_add() rather than opencoded variations

2018-08-17 Thread Jan Beulich
>>> On 15.08.18 at 20:34, wrote: > --- a/xen/arch/x86/mm/hap/hap.c > +++ b/xen/arch/x86/mm/hap/hap.c > @@ -729,7 +729,8 @@ hap_write_p2m_entry(struct domain *d, unsigned long gfn, > l1_pgentry_t *p, > * unless the only change is an increase in access rights. */ > mfn_t omfn =

Re: [Xen-devel] [PATCH 1/6] x86/mm: Use mfn_eq()/mfn_add() rather than opencoded variations

2018-08-16 Thread Roger Pau Monné
On Wed, Aug 15, 2018 at 07:34:32PM +0100, Andrew Cooper wrote: > Use l1e_get_mfn() in place of l1e_get_pfn() when applicable, and fix up style > on affected lines. > > For sh_remove_shadow_via_pointer(), map_domain_page() is guaranteed to succeed > so there is no need to ASSERT() its success.

[Xen-devel] [PATCH 1/6] x86/mm: Use mfn_eq()/mfn_add() rather than opencoded variations

2018-08-15 Thread Andrew Cooper
Use l1e_get_mfn() in place of l1e_get_pfn() when applicable, and fix up style on affected lines. For sh_remove_shadow_via_pointer(), map_domain_page() is guaranteed to succeed so there is no need to ASSERT() its success. This allows the pointer arithmetic to folded into the previous expression,