Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-09-07 Thread Jan Beulich
>>> On 07.09.18 at 16:47, wrote: > On 28/06/18 14:56, Jan Beulich wrote: > On 28.06.18 at 15:36, wrote: >>> On 28/06/18 14:00, Jan Beulich wrote: >>> On 26.06.18 at 15:18, wrote: > @@ -49,6 +28,18 @@ > #define ARCH_CAPS_RSBA (_AC(1, ULL) << 2) > #define AR

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-09-07 Thread Andrew Cooper
On 28/06/18 14:56, Jan Beulich wrote: On 28.06.18 at 15:36, wrote: >> On 28/06/18 14:00, Jan Beulich wrote: >> On 26.06.18 at 15:18, wrote: @@ -49,6 +28,18 @@ #define ARCH_CAPS_RSBA(_AC(1, ULL) << 2) #define ARCH_CAPS_SSB_NO (_AC(1, ULL) << 4

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-28 Thread Jan Beulich
>>> On 28.06.18 at 15:36, wrote: > On 28/06/18 14:00, Jan Beulich wrote: > On 26.06.18 at 15:18, wrote: >>> @@ -49,6 +28,18 @@ >>> #define ARCH_CAPS_RSBA (_AC(1, ULL) << 2) >>> #define ARCH_CAPS_SSB_NO (_AC(1, ULL) << 4) >>> >>> +#define MSR_EFER

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-28 Thread Andrew Cooper
On 28/06/18 14:00, Jan Beulich wrote: On 26.06.18 at 15:18, wrote: >> @@ -49,6 +28,18 @@ >> #define ARCH_CAPS_RSBA (_AC(1, ULL) << 2) >> #define ARCH_CAPS_SSB_NO(_AC(1, ULL) << 4) >> >> +#define MSR_EFER0xc080 /* Extended Featur

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-28 Thread Jan Beulich
>>> On 26.06.18 at 15:18, wrote: > @@ -49,6 +28,18 @@ > #define ARCH_CAPS_RSBA (_AC(1, ULL) << 2) > #define ARCH_CAPS_SSB_NO (_AC(1, ULL) << 4) > > +#define MSR_EFER0xc080 /* Extended Feature > Enable Register */ > +#define EFER_SC

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-27 Thread Andrew Cooper
On 27/06/18 11:39, Roger Pau Monné wrote: > On Tue, Jun 26, 2018 at 02:18:13PM +0100, Andrew Cooper wrote: >> The bit position constants are only used by the trampoline asm, but the >> code is shorter and clearer when using the mask constants. This halves >> the number of constants used. >> >> Con

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-27 Thread Roger Pau Monné
On Tue, Jun 26, 2018 at 02:18:13PM +0100, Andrew Cooper wrote: > The bit position constants are only used by the trampoline asm, but the > code is shorter and clearer when using the mask constants. This halves > the number of constants used. > > Consistently use _AC() for the bit constants, and s

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-26 Thread Wei Liu
On Tue, Jun 26, 2018 at 02:18:13PM +0100, Andrew Cooper wrote: > The bit position constants are only used by the trampoline asm, but the > code is shorter and clearer when using the mask constants. This halves > the number of constants used. > > Consistently use _AC() for the bit constants, and s

[Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-26 Thread Andrew Cooper
The bit position constants are only used by the trampoline asm, but the code is shorter and clearer when using the mask constants. This halves the number of constants used. Consistently use _AC() for the bit constants, and start to use spaces for indentation. Furthermore, EFER contains the NX-En