Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

2018-03-23 Thread Jan Beulich
>>> On 19.03.18 at 20:13, wrote: > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -539,14 +539,37 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) > u_domctl) > break; > } > > +/* Stash the new domid for the toolstack. */ > +op->domain = d

Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

2018-03-21 Thread Wei Liu
On Mon, Mar 19, 2018 at 07:13:50PM +, Andrew Cooper wrote: > XEN_DOMCTL_set_gnttab_limits is a fairly new hypercall, and is strictly > mandatory. Adding support for it introduced a state where a domain has a > mostly un-constructed grant table, and there were cases where mis-ordering of > tool

Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

2018-03-20 Thread Christian Lindig
> On 20. Mar 2018, at 10:11, Andrew Cooper wrote: > > That said, while ssidref might plausibly need a full 32 bits of range > (and even then, I'm not entirely sure, but it is an opaque handle at the > end of the day), none of the max_* fields do. vcpus is currently capped > at 128, grant frame

Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

2018-03-20 Thread Daniel De Graaf
On 03/19/2018 03:13 PM, Andrew Cooper wrote: XEN_DOMCTL_set_gnttab_limits is a fairly new hypercall, and is strictly mandatory. Adding support for it introduced a state where a domain has a mostly un-constructed grant table, and there were cases where mis-ordering of toolstack hypercalls could c

Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

2018-03-20 Thread Andrew Cooper
On 19/03/2018 21:43, Christian Lindig wrote: > >> On 19. Mar 2018, at 19:13, Andrew Cooper wrote: >> >> +max_grant_frames: int32; >> +max_maptrack_frames: int32; > As part of: > >> +type domctl_create_config = >> +{ >> + ssidref: int32; >> + handle: string; >> + flags: do

Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

2018-03-19 Thread Christian Lindig
> On 19. Mar 2018, at 19:13, Andrew Cooper wrote: > > + max_grant_frames: int32; > + max_maptrack_frames: int32; As part of: > +type domctl_create_config = > +{ > + ssidref: int32; > + handle: string; > + flags: domain_create_flag list; > + max_vcpus: int32; >

[Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

2018-03-19 Thread Andrew Cooper
XEN_DOMCTL_set_gnttab_limits is a fairly new hypercall, and is strictly mandatory. Adding support for it introduced a state where a domain has a mostly un-constructed grant table, and there were cases where mis-ordering of toolstack hypercalls could cause a NULL pointer deference in the hypervisor