Re: [Xen-devel] [PATCH 2/2] amd-iommu: use a bitfield for DTE

2019-02-12 Thread Woods, Brian
On 2/4/19 5:19 AM, Paul Durrant wrote: > The current use of get/set_field_from/in_reg_u32() is both inefficient and > requires some ugly casting. > > This patch defines a new bitfield structure (amd_iommu_dte) and uses this > structure in all DTE manipulation, resulting in much more readable and

[Xen-devel] [PATCH 2/2] amd-iommu: use a bitfield for DTE

2019-02-04 Thread Paul Durrant
The current use of get/set_field_from/in_reg_u32() is both inefficient and requires some ugly casting. This patch defines a new bitfield structure (amd_iommu_dte) and uses this structure in all DTE manipulation, resulting in much more readable and compact code. NOTE: This patch also includes