Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h

2020-01-08 Thread Durrant, Paul
> Subject: Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from > hyperv-tlfs.h > > On Wed, Jan 08, 2020 at 09:11:12AM +, Paul Durrant wrote: > > On Tue, 7 Jan 2020 at 17:39, Wei Liu wrote: > > > > > > All structures are already natura

Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h

2020-01-08 Thread Jan Beulich
On 07.01.2020 18:39, Wei Liu wrote: > All structures are already naturally aligned. Linux added those > attributes out of paranoia. > > In Xen we've had instance we had to drop pointless __packed to placate > gcc 9 (see ca9310b24e), it is better drop those attributes. > > Requested-by: Jan

Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h

2020-01-08 Thread Wei Liu
On Wed, Jan 08, 2020 at 09:11:12AM +, Paul Durrant wrote: > On Tue, 7 Jan 2020 at 17:39, Wei Liu wrote: > > > > All structures are already naturally aligned. Linux added those > > attributes out of paranoia. > > > > In Xen we've had instance we had to drop pointless __packed to placate > >

Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h

2020-01-08 Thread Paul Durrant
On Tue, 7 Jan 2020 at 17:39, Wei Liu wrote: > > All structures are already naturally aligned. Linux added those > attributes out of paranoia. > > In Xen we've had instance we had to drop pointless __packed to placate > gcc 9 (see ca9310b24e I think you should add: "x86/IO-APIC: fix build with

[Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h

2020-01-07 Thread Wei Liu
All structures are already naturally aligned. Linux added those attributes out of paranoia. In Xen we've had instance we had to drop pointless __packed to placate gcc 9 (see ca9310b24e), it is better drop those attributes. Requested-by: Jan Beulich Signed-off-by: Wei Liu ---