[Xen-devel] [PATCH 2/2] x86/traps: widen condition for logging top-of-stack

2019-05-31 Thread Jan Beulich
Despite -fno-omit-frame-pointer the compiler may omit the frame pointer, often for relatively simple leaf functions. (To give a specific example, the case I've run into this with is _pci_hide_device() and gcc 8. Interestingly the even more simple neighboring iommu_has_feature() does get a frame poi

Re: [Xen-devel] [PATCH 2/2] x86/traps: widen condition for logging top-of-stack

2019-06-07 Thread Andrew Cooper
On 31/05/2019 10:22, Jan Beulich wrote: > Despite -fno-omit-frame-pointer the compiler may omit the frame pointer, > often for relatively simple leaf functions. (To give a specific example, > the case I've run into this with is _pci_hide_device() and gcc 8. > Interestingly the even more simple neig

Re: [Xen-devel] [PATCH 2/2] x86/traps: widen condition for logging top-of-stack

2019-06-11 Thread Jan Beulich
>>> On 07.06.19 at 20:01, wrote: > On 31/05/2019 10:22, Jan Beulich wrote: >> Despite -fno-omit-frame-pointer the compiler may omit the frame pointer, >> often for relatively simple leaf functions. (To give a specific example, >> the case I've run into this with is _pci_hide_device() and gcc 8. >>