Re: [Xen-devel] [PATCH 2/4] x86/mm: rename and tidy create_pae_xen_mappings()

2020-01-06 Thread Jan Beulich
On 20.12.2019 16:33, Andrew Cooper wrote: > On 20/12/2019 14:19, Jan Beulich wrote: >> After dad74b0f9e ("i386: fix handling of Xen entries in final L2 page >> table") and the removal of 32-bit support the function doesn't modify >> state anymore, and hence its name has been misleading. Change its

Re: [Xen-devel] [PATCH 2/4] x86/mm: rename and tidy create_pae_xen_mappings()

2019-12-20 Thread Andrew Cooper
On 20/12/2019 14:19, Jan Beulich wrote: > After dad74b0f9e ("i386: fix handling of Xen entries in final L2 page > table") and the removal of 32-bit support the function doesn't modify > state anymore, and hence its name has been misleading. Change its name, > constify parameters and a local variabl

[Xen-devel] [PATCH 2/4] x86/mm: rename and tidy create_pae_xen_mappings()

2019-12-20 Thread Jan Beulich
After dad74b0f9e ("i386: fix handling of Xen entries in final L2 page table") and the removal of 32-bit support the function doesn't modify state anymore, and hence its name has been misleading. Change its name, constify parameters and a local variable, and make it return bool. Also drop the call