Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Roger Pau Monné
On Tue, Dec 17, 2019 at 12:26:24PM +, Andrew Cooper wrote: > On 17/12/2019 12:18, Roger Pau Monné wrote: > > On Tue, Dec 17, 2019 at 12:06:01PM +, Andrew Cooper wrote: > >> On 17/12/2019 11:52, Roger Pau Monné wrote: > >>> On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: > >>>

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Andrew Cooper
On 17/12/2019 12:18, Roger Pau Monné wrote: > On Tue, Dec 17, 2019 at 12:06:01PM +, Andrew Cooper wrote: >> On 17/12/2019 11:52, Roger Pau Monné wrote: >>> On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: The trampoline has already set up the idle pagetables (which are the >

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Roger Pau Monné
On Tue, Dec 17, 2019 at 12:06:01PM +, Andrew Cooper wrote: > On 17/12/2019 11:52, Roger Pau Monné wrote: > > On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: > >> The trampoline has already set up the idle pagetables (which are the > >> correct > >> ones to use), and sanitised th

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Andrew Cooper
On 17/12/2019 11:52, Roger Pau Monné wrote: > On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: >> The trampoline has already set up the idle pagetables (which are the correct >> ones to use), and sanitised the flags state. > I wonder why do we have wakeup.S and wakeup_prot.S, it would

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: > The trampoline has already set up the idle pagetables (which are the correct > ones to use), and sanitised the flags state. I wonder why do we have wakeup.S and wakeup_prot.S, it would be easier to follow if it all was in the same fi

[Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-13 Thread Andrew Cooper
The trampoline has already set up the idle pagetables (which are the correct ones to use), and sanitised the flags state. For %ss, __HYPERVISOR_DS64 is the correct descriptor to restore. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/acpi/wa