Re: [Xen-devel] [PATCH 27/34] x86: make hvm_inject_* functions build when !CONFIG_HVM

2018-08-24 Thread Wei Liu
On Tue, Aug 21, 2018 at 10:37:24AM +0200, Roger Pau Monné wrote: > On Fri, Aug 17, 2018 at 04:12:45PM +0100, Wei Liu wrote: > > They reference hvm_inject_event which is HVM code (not compiled). They > > aren't used by code outside HVM code anyway. > > Can you put all the functions inside of an

Re: [Xen-devel] [PATCH 27/34] x86: make hvm_inject_* functions build when !CONFIG_HVM

2018-08-21 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > They reference hvm_inject_event which is HVM code (not compiled). They > aren't used by code outside HVM code anyway. Again looks to be a case of DCE doing its job (if arranged for properly) instead of adding #ifdef-s to functions which ought to be entirely

Re: [Xen-devel] [PATCH 27/34] x86: make hvm_inject_* functions build when !CONFIG_HVM

2018-08-21 Thread Roger Pau Monné
On Fri, Aug 17, 2018 at 04:12:45PM +0100, Wei Liu wrote: > They reference hvm_inject_event which is HVM code (not compiled). They > aren't used by code outside HVM code anyway. Can you put all the functions inside of an #ifdef CONFIG_HVM instead of making them no-ops? Thanks, Roger.

[Xen-devel] [PATCH 27/34] x86: make hvm_inject_* functions build when !CONFIG_HVM

2018-08-17 Thread Wei Liu
They reference hvm_inject_event which is HVM code (not compiled). They aren't used by code outside HVM code anyway. Signed-off-by: Wei Liu --- xen/include/asm-x86/hvm/hvm.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h