[Xen-devel] [PATCH 3/3] AMD/IOMMU: replace a few literal numbers

2020-02-05 Thread Jan Beulich
Introduce IOMMU_PDE_NEXT_LEVEL_{MIN,MAX} to replace literal 1, 6, and 7 instances. While doing so replace two uses of memset() by initializers. Signed-off-by: Jan Beulich --- TBD: We should really honor the hats field of union amd_iommu_ext_features, but the specification (or at least the

Re: [Xen-devel] [PATCH 3/3] AMD/IOMMU: replace a few literal numbers

2020-02-10 Thread Andrew Cooper
On 05/02/2020 09:43, Jan Beulich wrote: > Introduce IOMMU_PDE_NEXT_LEVEL_{MIN,MAX} to replace literal 1, 6, and 7 > instances. While doing so replace two uses of memset() by initializers. > > Signed-off-by: Jan Beulich This does not look to be an improvement.  IOMMU_PDE_NEXT_LEVEL_MIN is definite

Re: [Xen-devel] [PATCH 3/3] AMD/IOMMU: replace a few literal numbers

2020-02-17 Thread Jan Beulich
On 10.02.2020 15:28, Andrew Cooper wrote: > On 05/02/2020 09:43, Jan Beulich wrote: >> Introduce IOMMU_PDE_NEXT_LEVEL_{MIN,MAX} to replace literal 1, 6, and 7 >> instances. While doing so replace two uses of memset() by initializers. >> >> Signed-off-by: Jan Beulich > > This does not look to be a

Re: [Xen-devel] [PATCH 3/3] AMD/IOMMU: replace a few literal numbers

2020-02-17 Thread Andrew Cooper
On 17/02/2020 13:09, Jan Beulich wrote: > On 10.02.2020 15:28, Andrew Cooper wrote: >> On 05/02/2020 09:43, Jan Beulich wrote: >>> Introduce IOMMU_PDE_NEXT_LEVEL_{MIN,MAX} to replace literal 1, 6, and 7 >>> instances. While doing so replace two uses of memset() by initializers. >>> >>> Signed-off-b

Re: [Xen-devel] [PATCH 3/3] AMD/IOMMU: replace a few literal numbers

2020-02-17 Thread Jan Beulich
On 17.02.2020 20:06, Andrew Cooper wrote: > On 17/02/2020 13:09, Jan Beulich wrote: >> On 10.02.2020 15:28, Andrew Cooper wrote: >>> On 05/02/2020 09:43, Jan Beulich wrote: Introduce IOMMU_PDE_NEXT_LEVEL_{MIN,MAX} to replace literal 1, 6, and 7 instances. While doing so replace two uses o