Re: [Xen-devel] [PATCH 3/3] tools: ipxe: Correct download error handling

2018-11-06 Thread Wei Liu
On Mon, Nov 05, 2018 at 06:42:34PM +, Ian Jackson wrote: > This shell fragment lacked set -e. So, eg if the download failed a > broken ipxe.tar.gz would be left behind. > > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 3/3] tools: ipxe: Correct download error handling

2018-11-06 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 06 November 2018 08:44 > To: Ian Jackson ; xen-devel@lists.xenproject.org > Cc: Ian Jackson ; Wei Liu > Subject: Re: [Xen-devel] [PATCH 3/3]

Re: [Xen-devel] [PATCH 3/3] tools: ipxe: Correct download error handling

2018-11-06 Thread Paul Durrant
> -Original Message- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: 05 November 2018 18:43 > To: xen-devel@lists.xenproject.org > Cc: Ian Jackson ; Paul Durrant > ; Wei Liu > Subject: [PATCH 3/3] tools: ipxe: Correct download error handling > > This shell fragment lacked s

[Xen-devel] [PATCH 3/3] tools: ipxe: Correct download error handling

2018-11-05 Thread Ian Jackson
This shell fragment lacked set -e. So, eg if the download failed a broken ipxe.tar.gz would be left behind. Signed-off-by: Ian Jackson CC: Paul Durrant CC: Wei Liu --- tools/firmware/etherboot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/firmware/etherboo