Re: [Xen-devel] [PATCH 3/3] x86/emul: Improvements to internal users of decode_register()

2018-01-29 Thread Jan Beulich
>>> On 26.01.18 at 14:16, wrote: > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -1980,9 +1980,8 @@ load_seg( > return rc; > } > > -void * > -decode_register( > -uint8_t modrm_reg, struct cpu_user_regs

[Xen-devel] [PATCH 3/3] x86/emul: Improvements to internal users of decode_register()

2018-01-26 Thread Andrew Cooper
Most users of decode_register() can be replaced with decode_gpr() right away. For the few sites which do care about possibly using the highbyte encoding, rename decode_register() to decode_high_gpr() and make it prototype match decode_gpr(). Signed-off-by: Andrew Cooper