[Xen-devel] [PATCH 3/3] x86/spec-ctrl: Add support for modifying SSBD AMD VIA LS_CFG MSR

2018-07-20 Thread Brian Woods
Adds support for modifying the LS_CFG MSR to enable SSBD on supporting AMD CPUs. There needs to be locking logic for family 17h with SMT enabled since both threads share the same MSR. Otherwise, a core just needs to write to the LS_CFG MSR. For more information see: https://developer.amd.com/wp

Re: [Xen-devel] [PATCH 3/3] x86/spec-ctrl: Add support for modifying SSBD AMD VIA LS_CFG MSR

2018-07-31 Thread Jan Beulich
>>> On 20.07.18 at 16:57, wrote: > --- a/xen/arch/x86/cpu/amd.c > +++ b/xen/arch/x86/cpu/amd.c > @@ -607,16 +607,10 @@ static void init_amd(struct cpuinfo_x86 *c) > case 0x17: bit = 10; break; > } > > - if (bit >= 0) > - ssbd_amd_ls_cfg

Re: [Xen-devel] [PATCH 3/3] x86/spec-ctrl: Add support for modifying SSBD AMD VIA LS_CFG MSR

2018-08-01 Thread Brian Woods
On Tue, Jul 31, 2018 at 05:25:27AM -0600, Jan Beulich wrote: > Code structure wise this looks to undo a fair part of what patch > 1 has done. It would be nice to limit code churn. Patch 1 stand alone just to improve reporting the capabilities of the processor. Currently Xen doesn't mention anythi

Re: [Xen-devel] [PATCH 3/3] x86/spec-ctrl: Add support for modifying SSBD AMD VIA LS_CFG MSR

2018-08-02 Thread Jan Beulich
>>> On 02.08.18 at 00:20, wrote: > On Tue, Jul 31, 2018 at 05:25:27AM -0600, Jan Beulich wrote: >> Code structure wise this looks to undo a fair part of what patch >> 1 has done. It would be nice to limit code churn. > > Patch 1 stand alone just to improve reporting the capabilities of the > proc

Re: [Xen-devel] [PATCH 3/3] x86/spec-ctrl: Add support for modifying SSBD AMD VIA LS_CFG MSR

2018-08-06 Thread Brian Woods
On Thu, Aug 02, 2018 at 01:09:06AM -0600, Jan Beulich wrote: > >>> On 02.08.18 at 00:20, wrote: > > On Tue, Jul 31, 2018 at 05:25:27AM -0600, Jan Beulich wrote: > >> Code structure wise this looks to undo a fair part of what patch > >> 1 has done. It would be nice to limit code churn. > > > > Pat

Re: [Xen-devel] [PATCH 3/3] x86/spec-ctrl: Add support for modifying SSBD AMD VIA LS_CFG MSR

2018-08-07 Thread Jan Beulich
>>> On 06.08.18 at 21:07, wrote: > On Thu, Aug 02, 2018 at 01:09:06AM -0600, Jan Beulich wrote: >> >>> On 02.08.18 at 00:20, wrote: >> > On Tue, Jul 31, 2018 at 05:25:27AM -0600, Jan Beulich wrote: >> >> Code structure wise this looks to undo a fair part of what patch >> >> 1 has done. It would b

Re: [Xen-devel] [PATCH 3/3] x86/spec-ctrl: Add support for modifying SSBD AMD VIA LS_CFG MSR

2018-08-08 Thread Brian Woods
On Tue, Aug 07, 2018 at 01:51:07AM -0600, Jan Beulich wrote: > >>> On 06.08.18 at 21:07, wrote: > > On Thu, Aug 02, 2018 at 01:09:06AM -0600, Jan Beulich wrote: > >> >>> On 02.08.18 at 00:20, wrote: > >> > On Tue, Jul 31, 2018 at 05:25:27AM -0600, Jan Beulich wrote: > >> >> Code structure wise th

Re: [Xen-devel] [PATCH 3/3] x86/spec-ctrl: Add support for modifying SSBD AMD VIA LS_CFG MSR

2018-08-08 Thread Jan Beulich
>>> On 08.08.18 at 18:43, wrote: > On Tue, Aug 07, 2018 at 01:51:07AM -0600, Jan Beulich wrote: >> >>> On 06.08.18 at 21:07, wrote: >> > On Thu, Aug 02, 2018 at 01:09:06AM -0600, Jan Beulich wrote: >> >> >>> On 02.08.18 at 00:20, wrote: >> >> > current_cpu_data isn't available when ssbd_amd_ls_c