Re: [Xen-devel] [PATCH 3/3] xen/x86: Rename and simplify async_event_* infrastructure

2020-02-20 Thread Andrew Cooper
On 18/02/2020 16:31, Jan Beulich wrote: > On 17.02.2020 12:17, Andrew Cooper wrote: >> --- a/xen/arch/x86/pv/iret.c >> +++ b/xen/arch/x86/pv/iret.c >> @@ -27,15 +27,15 @@ static void async_exception_cleanup(struct vcpu *curr) >> { >> unsigned int trap; >> >> -if (

Re: [Xen-devel] [PATCH 3/3] xen/x86: Rename and simplify async_event_* infrastructure

2020-02-18 Thread Jan Beulich
On 17.02.2020 12:17, Andrew Cooper wrote: > --- a/xen/arch/x86/pv/iret.c > +++ b/xen/arch/x86/pv/iret.c > @@ -27,15 +27,15 @@ static void async_exception_cleanup(struct vcpu *curr) > { > unsigned int trap; > > -if ( !curr->arch.async_exception_mask ) > +if (

[Xen-devel] [PATCH 3/3] xen/x86: Rename and simplify async_event_* infrastructure

2020-02-17 Thread Andrew Cooper
The name async_exception isn't appropriate. NMI isn't an exception at all, and while MCE is classified as an exception (i.e. can occur at any point), the mechanics of injecting it behave like other external interrupts. Rename to async_event_* which is a little shorter. Drop VCPU_TRAP_NONE and