Re: [Xen-devel] [PATCH 3/8] xen/sched: don't use irqsave locks in dumping functions

2020-02-19 Thread Dario Faggioli
On Wed, 2020-02-19 at 16:02 +0100, Jürgen Groß wrote: > On 19.02.20 15:27, Jan Beulich wrote: > > On 13.02.2020 13:54, Juergen Gross wrote: > > > All dumping functions invoked by the "runq" keyhandler are called > > > with > > > disabled interrupts, > > > > Is this actually needed for anything? It

Re: [Xen-devel] [PATCH 3/8] xen/sched: don't use irqsave locks in dumping functions

2020-02-19 Thread Jürgen Groß
On 19.02.20 15:27, Jan Beulich wrote: On 13.02.2020 13:54, Juergen Gross wrote: All dumping functions invoked by the "runq" keyhandler are called with disabled interrupts, Is this actually needed for anything? It means not servicing interrupts for perhaps an extended period of time. Debug keys

Re: [Xen-devel] [PATCH 3/8] xen/sched: don't use irqsave locks in dumping functions

2020-02-19 Thread Jan Beulich
On 13.02.2020 13:54, Juergen Gross wrote: > All dumping functions invoked by the "runq" keyhandler are called with > disabled interrupts, Is this actually needed for anything? It means not servicing interrupts for perhaps an extended period of time. Debug keys aren't promised to be non-intrusive,

Re: [Xen-devel] [PATCH 3/8] xen/sched: don't use irqsave locks in dumping functions

2020-02-19 Thread Dario Faggioli
On Thu, 2020-02-13 at 13:54 +0100, Juergen Gross wrote: > All dumping functions invoked by the "runq" keyhandler are called > with > disabled interrupts, so there is no need to use the irqsave variants > of any locks in those functions. > > To me, this patch looks pretty independent from the seri

[Xen-devel] [PATCH 3/8] xen/sched: don't use irqsave locks in dumping functions

2020-02-13 Thread Juergen Gross
All dumping functions invoked by the "runq" keyhandler are called with disabled interrupts, so there is no need to use the irqsave variants of any locks in those functions. Signed-off-by: Juergen Gross --- xen/common/sched/credit.c | 10 -- xen/common/sched/credit2.c | 5 ++--- xen/com